From: <pannengyuan@huawei.com>
To: <mst@redhat.com>, <pbonzini@redhat.com>, <fam@euphon.net>
Cc: Pan Nengyuan <pannengyuan@huawei.com>,
qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com
Subject: [PATCH 2/2] virtio-scsi: convert to new virtio_delete_queue
Date: Fri, 17 Jan 2020 15:55:47 +0800 [thread overview]
Message-ID: <20200117075547.60864-3-pannengyuan@huawei.com> (raw)
In-Reply-To: <20200117075547.60864-1-pannengyuan@huawei.com>
From: Pan Nengyuan <pannengyuan@huawei.com>
Use virtio_delete_queue to make it more clear.
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
---
hw/scsi/virtio-scsi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index 858b3aaccb..d3af42ef92 100644
--- a/hw/scsi/virtio-scsi.c
+++ b/hw/scsi/virtio-scsi.c
@@ -945,10 +945,10 @@ void virtio_scsi_common_unrealize(DeviceState *dev)
VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(dev);
int i;
- virtio_del_queue(vdev, 0);
- virtio_del_queue(vdev, 1);
+ virtio_delete_queue(vs->ctrl_vq);
+ virtio_delete_queue(vs->event_vq);
for (i = 0; i < vs->conf.num_queues; i++) {
- virtio_del_queue(vdev, i + 2);
+ virtio_delete_queue(vs->cmd_vqs[i]);
}
g_free(vs->cmd_vqs);
virtio_cleanup(vdev);
--
2.21.0.windows.1
next prev parent reply other threads:[~2020-01-17 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 7:55 [PATCH 0/2] delete virtio queues in virtio_scsi_unrealize pannengyuan
2020-01-17 7:55 ` [PATCH 1/2] virtio-scsi: delete vqs in unrealize to avoid memleaks pannengyuan
2020-01-17 7:55 ` pannengyuan [this message]
2020-01-20 14:35 ` [PATCH 0/2] delete virtio queues in virtio_scsi_unrealize Stefan Hajnoczi
2020-01-21 16:23 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117075547.60864-3-pannengyuan@huawei.com \
--to=pannengyuan@huawei.com \
--cc=fam@euphon.net \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).