From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCBA6C2D0CE for ; Tue, 21 Jan 2020 12:49:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B9C92064C for ; Tue, 21 Jan 2020 12:49:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HIGkWcO+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B9C92064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itsyT-0004Zg-5T for qemu-devel@archiver.kernel.org; Tue, 21 Jan 2020 07:49:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51389) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itscP-0007Ee-Ua for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:26:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itscO-0002It-O7 for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:26:53 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:22382 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itscO-0002Hv-K0 for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:26:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579609612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5AgYBT4wAsjhnwF7AhBOcOEdSTo7yDf+Qnw9sPdGAvw=; b=HIGkWcO+ZBg83cEYgehKNt302LTiWfO37g6i525nror7GsjnayCV1KEtMzeZ/58fZOycoS FhJu0/FdYDpf6EE9lA4+q6kZa5mlkxgtcHnI9c2XS5B5h7ioVLvjvGZBLRKiFPaWOby8MC euO8PA/qdkSHVlIUtNzsGyFazMKoYnw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-46-HiZaTxL0M-iz_otg8UTpxA-1; Tue, 21 Jan 2020 07:26:50 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DFCAC107ACC9; Tue, 21 Jan 2020 12:26:49 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3830A60BE0; Tue, 21 Jan 2020 12:26:48 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com, vgoyal@redhat.com, berrange@redhat.com, slp@redhat.com, philmd@redhat.com Subject: [PATCH v2 029/109] virtiofsd: make -f (foreground) the default Date: Tue, 21 Jan 2020 12:23:13 +0000 Message-Id: <20200121122433.50803-30-dgilbert@redhat.com> In-Reply-To: <20200121122433.50803-1-dgilbert@redhat.com> References: <20200121122433.50803-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: HiZaTxL0M-iz_otg8UTpxA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: m.mizuma@jp.fujitsu.com, misono.tomohiro@jp.fujitsu.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Stefan Hajnoczi According to vhost-user.rst "Backend program conventions", backend programs should run in the foregound by default. Follow the conventions so libvirt and other management tools can control virtiofsd in a standard way. Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrang=C3=A9 --- tools/virtiofsd/helper.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c index 1dc497a7ca..bb35b90e75 100644 --- a/tools/virtiofsd/helper.c +++ b/tools/virtiofsd/helper.c @@ -28,6 +28,11 @@ { \ t, offsetof(struct fuse_cmdline_opts, p), 1 \ } +#define FUSE_HELPER_OPT_VALUE(t, p, v) \ + { \ + t, offsetof(struct fuse_cmdline_opts, p), v \ + } + =20 static const struct fuse_opt fuse_helper_opts[] =3D { FUSE_HELPER_OPT("-h", show_help), @@ -41,6 +46,7 @@ static const struct fuse_opt fuse_helper_opts[] =3D { FUSE_OPT_KEY("-d", FUSE_OPT_KEY_KEEP), FUSE_OPT_KEY("debug", FUSE_OPT_KEY_KEEP), FUSE_HELPER_OPT("-f", foreground), + FUSE_HELPER_OPT_VALUE("--daemonize", foreground, 0), FUSE_HELPER_OPT("-s", singlethread), FUSE_HELPER_OPT("fsname=3D", nodefault_subtype), FUSE_OPT_KEY("fsname=3D", FUSE_OPT_KEY_KEEP), @@ -131,6 +137,7 @@ void fuse_cmdline_help(void) " -V --version print version\n" " -d -o debug enable debug output (implies -f= )\n" " -f foreground operation\n" + " --daemonize run in background\n" " -s disable multi-threaded operatio= n\n" " -o max_idle_threads the maximum number of idle work= er " "threads\n" @@ -159,6 +166,7 @@ int fuse_parse_cmdline(struct fuse_args *args, struct f= use_cmdline_opts *opts) memset(opts, 0, sizeof(struct fuse_cmdline_opts)); =20 opts->max_idle_threads =3D 10; + opts->foreground =3D 1; =20 if (fuse_opt_parse(args, opts, fuse_helper_opts, fuse_helper_opt_proc)= =3D=3D -1) { --=20 2.24.1