From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org, armbru@redhat.com,
marcandre.lureau@gmail.com, stefanha@redhat.com
Subject: [PATCH v4 0/4] qmp: Optionally run handlers in coroutines
Date: Tue, 21 Jan 2020 19:11:18 +0100 [thread overview]
Message-ID: <20200121181122.15941-1-kwolf@redhat.com> (raw)
Some QMP command handlers can block the main loop for a relatively long
time, for example because they perform some I/O. This is quite nasty.
Allowing such handlers to run in a coroutine where they can yield (and
therefore release the BQL) while waiting for an event such as I/O
completion solves the problem.
This series adds the infrastructure to allow this and switches
block_resize to run in a coroutine as a first example.
This is an alternative solution to Marc-André's "monitor: add
asynchronous command type" series.
v4:
- Forbid 'oob': true, 'coroutine': true [Markus]
- Removed Python type hints [Markus]
- Introduced separate bool qmp_dispatcher_co_shutdown to make it clearer
how a shutdown request is signalled to the dispatcher [Markus]
- Allow using aio_poll() with iohandler_ctx and use that instead of
aio_bh_poll() [Markus]
- Removed coroutine_fn from qmp_block_resize() again because at least
one caller (HMP) calls it outside of coroutine context [Markus]
- Tried to make the synchronisation between dispatcher and the monitor
thread clearer, and fixed a race condition
- Improved documentation and comments
v3:
- Fix race between monitor thread and dispatcher that could schedule the
dispatcher coroutine twice if a second requests comes in before the
dispatcher can wake up [Patchew]
v2:
- Fix typo in a commit message [Eric]
- Use hyphen instead of underscore for the test command [Eric]
- Mark qmp_block_resize() as coroutine_fn [Stefan]
Kevin Wolf (4):
qapi: Add a 'coroutine' flag for commands
vl: Initialise main loop earlier
qmp: Move dispatcher to a coroutine
block: Mark 'block_resize' as coroutine
qapi/block-core.json | 3 +-
docs/devel/qapi-code-gen.txt | 10 +++
include/qapi/qmp/dispatch.h | 2 +
monitor/monitor-internal.h | 6 +-
monitor/monitor.c | 33 +++++--
monitor/qmp.c | 110 +++++++++++++++++-------
qapi/qmp-dispatch.c | 44 +++++++++-
qapi/qmp-registry.c | 3 +
tests/test-qmp-cmds.c | 4 +
util/aio-posix.c | 7 +-
vl.c | 10 +--
scripts/qapi/commands.py | 10 ++-
scripts/qapi/doc.py | 2 +-
scripts/qapi/expr.py | 7 +-
scripts/qapi/introspect.py | 2 +-
scripts/qapi/schema.py | 9 +-
tests/qapi-schema/test-qapi.py | 7 +-
tests/Makefile.include | 1 +
tests/qapi-schema/oob-coroutine.err | 2 +
tests/qapi-schema/oob-coroutine.json | 2 +
tests/qapi-schema/oob-coroutine.out | 0
tests/qapi-schema/qapi-schema-test.json | 1 +
tests/qapi-schema/qapi-schema-test.out | 2 +
23 files changed, 216 insertions(+), 61 deletions(-)
create mode 100644 tests/qapi-schema/oob-coroutine.err
create mode 100644 tests/qapi-schema/oob-coroutine.json
create mode 100644 tests/qapi-schema/oob-coroutine.out
--
2.20.1
next reply other threads:[~2020-01-21 18:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 18:11 Kevin Wolf [this message]
2020-01-21 18:11 ` [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands Kevin Wolf
2020-01-22 6:32 ` Markus Armbruster
2020-01-22 10:10 ` Kevin Wolf
2020-01-22 12:15 ` Markus Armbruster
2020-01-22 14:35 ` Kevin Wolf
2020-03-05 15:30 ` Markus Armbruster
2020-03-05 16:06 ` Kevin Wolf
2020-03-06 7:25 ` Markus Armbruster
2020-03-06 9:52 ` Kevin Wolf
2020-03-06 12:38 ` Markus Armbruster
2020-03-06 14:26 ` Kevin Wolf
2020-02-17 7:08 ` Markus Armbruster
2020-01-21 18:11 ` [PATCH v4 2/4] vl: Initialise main loop earlier Kevin Wolf
2020-01-21 18:11 ` [PATCH v4 3/4] qmp: Move dispatcher to a coroutine Kevin Wolf
2020-02-17 11:08 ` Markus Armbruster
2020-02-17 12:34 ` Kevin Wolf
2020-02-18 14:12 ` Markus Armbruster
2020-02-18 15:29 ` Kevin Wolf
2020-02-19 9:03 ` Markus Armbruster
2020-02-19 10:22 ` Kevin Wolf
2020-02-19 14:21 ` Markus Armbruster
2020-02-19 14:26 ` Markus Armbruster
2020-02-19 15:27 ` Kevin Wolf
2020-01-21 18:11 ` [PATCH v4 4/4] block: Mark 'block_resize' as coroutine Kevin Wolf
2020-02-05 14:00 ` [PATCH v4 0/4] qmp: Optionally run handlers in coroutines Kevin Wolf
2020-02-12 11:40 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121181122.15941-1-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).