From: "Jason J. Herne" <jjherne@linux.ibm.com>
To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, cohuck@redhat.com,
borntraeger@de.ibm.com
Subject: [PATCH] pc-bios/s390x: Pack ResetInfo struct
Date: Wed, 5 Feb 2020 13:21:26 -0500 [thread overview]
Message-ID: <20200205182126.13010-1-jjherne@linux.ibm.com> (raw)
This fixes vfio-ccw when booting non-Linux operating systems. Without this
struct being packed, a few extra bytes of low core memory get overwritten when
we assign a value to memory address 0 in jump_to_IPL_2. This is enough to
cause some non-Linux OSes of fail when booting.
The problem was introduced by:
5c6f0d5f46a77d77 "pc-bios/s390x: Fix reset psw mask".
The fix is to pack the struct thereby removing the 4 bytes of padding that get
added at the end, likely to allow an array of these structs to naturally align
on an 8-byte boundary.
Fixes: 5c6f0d5f46a7 ("pc-bios/s390x: Fix reset psw mask")
CC: Janosch Frank <frankja@linux.ibm.com>
Signed-off-by: Jason J. Herne <jjherne@linux.ibm.com>
---
pc-bios/s390-ccw/jump2ipl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/jump2ipl.c b/pc-bios/s390-ccw/jump2ipl.c
index da13c43cc0..1e9eaa037f 100644
--- a/pc-bios/s390-ccw/jump2ipl.c
+++ b/pc-bios/s390-ccw/jump2ipl.c
@@ -18,7 +18,7 @@
typedef struct ResetInfo {
uint64_t ipl_psw;
uint32_t ipl_continue;
-} ResetInfo;
+} __attribute__((packed)) ResetInfo;
static ResetInfo save;
--
2.21.1
next reply other threads:[~2020-02-05 18:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 18:21 Jason J. Herne [this message]
2020-02-06 9:55 ` [PATCH] pc-bios/s390x: Pack ResetInfo struct Cornelia Huck
2020-02-06 10:09 ` Christian Borntraeger
2020-02-06 11:00 ` Thomas Huth
2020-02-07 11:28 ` Christian Borntraeger
2020-02-07 14:02 ` Jason J. Herne
2020-08-27 10:07 ` Thomas Huth
2020-09-01 13:02 ` Jason J. Herne
2020-02-13 18:02 ` Jason J. Herne
2020-02-13 18:24 ` Christian Borntraeger
2020-02-25 10:23 ` Jason J. Herne
2020-02-25 11:13 ` Christian Borntraeger
2020-02-25 12:58 ` Jason J. Herne
2020-02-25 15:00 ` Christian Borntraeger
2020-02-25 15:05 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205182126.13010-1-jjherne@linux.ibm.com \
--to=jjherne@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).