From: Roman Kagan <rvkagan@yandex-team.ru>
To: Eric Blake <eblake@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH] block: make BlockConf.*_size properties 32-bit
Date: Thu, 13 Feb 2020 11:01:51 +0300 [thread overview]
Message-ID: <20200213080151.GA85593@rvkaganb> (raw)
In-Reply-To: <c79721ac-357f-6b9f-6d71-53f2cb72ef6e@redhat.com>
On Wed, Feb 12, 2020 at 03:44:19PM -0600, Eric Blake wrote:
> On 2/11/20 5:54 AM, Roman Kagan wrote:
> > Devices (virtio-blk, scsi, etc.) and the block layer are happy to use
> > 32-bit for logical_block_size, physical_block_size, and min_io_size.
> > However, the properties in BlockConf are defined as uint16_t limiting
> > the values to 32768.
> >
> > This appears unnecessary tight, and we've seen bigger block sizes handy
> > at times.
>
> What larger sizes? I could see 64k or maybe even 1M block sizes,...
We played exactly with these two :)
> >
> > Make them 32 bit instead and lift the limitation.
> >
> > Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru>
> > ---
> > hw/core/qdev-properties.c | 21 ++++++++++++---------
> > include/hw/block/block.h | 8 ++++----
> > include/hw/qdev-properties.h | 2 +-
> > 3 files changed, 17 insertions(+), 14 deletions(-)
> >
> > diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
> > index 7f93bfeb88..5f84e4a3b8 100644
> > --- a/hw/core/qdev-properties.c
> > +++ b/hw/core/qdev-properties.c
> > @@ -716,30 +716,32 @@ const PropertyInfo qdev_prop_pci_devfn = {
> > /* --- blocksize --- */
> > +#define MIN_BLOCK_SIZE 512
> > +#define MAX_BLOCK_SIZE 2147483648
>
> ...but 2G block sizes are going to have tremendous performance problems.
>
> I'm not necessarily opposed to the widening to a 32-bit type, but think you
> need more justification or a smaller number for the max block size,
I thought any smaller value would just be arbitrary and hard to reason
about, so I went ahead with the max value that fit in the type and could
be made visibile to the guest.
Besides this is a property that is set explicitly, so I don't see a
problem leaving this up to the user.
> particularly since qcow2 refuses to use cluster sizes larger than 2M and it
> makes no sense to allow a block size larger than a cluster size.
This still doesn't contradict passing a bigger value to the guest, for
experimenting if nothing else.
Thanks,
Roman.
next prev parent reply other threads:[~2020-02-13 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 11:54 [PATCH] block: make BlockConf.*_size properties 32-bit Roman Kagan
2020-02-12 21:44 ` Eric Blake
2020-02-13 8:01 ` Roman Kagan [this message]
2020-02-13 12:47 ` Eric Blake
2020-02-13 13:55 ` Roman Kagan
2020-03-02 10:55 ` Roman Kagan
2020-03-24 8:55 ` Roman Kagan
2020-03-24 9:21 ` Kevin Wolf
2020-03-24 14:27 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213080151.GA85593@rvkaganb \
--to=rvkagan@yandex-team.ru \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).