From: Gerd Hoffmann <kraxel@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Beniamino Galvani <b.galvani@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/3] arm: allwinner: Wire up USB EHCI
Date: Fri, 14 Feb 2020 11:08:37 +0100 [thread overview]
Message-ID: <20200214100837.lv2cok5he7epmu7i@sirius.home.kraxel.org> (raw)
In-Reply-To: <20200214062109.24494-3-linux@roeck-us.net>
> ehci-platform 1c1c000.usb: new USB bus registered, assigned bus number 2
> ehci-platform 1c1c000.usb: irq 31, io mem 0x01c1c000
> ehci-platform 1c1c000.usb: USB 2.0 started, EHCI 1.00
> + for (i = 0; i < ARRAY_SIZE(s->ehci); i++) {
> + object_property_set_bool(OBJECT(&s->ehci[i]), true, "realized",
> + &err);
I suspect the ohci controllers are ehci companions, i.e. they handle a
single usb bus, with ehci handling usb2 and ohci handling usb1 devices?
If so then you should initialize ehci first, explicitly assign bus
names and set the masterbus property for the ohci controllers.
See also docs/usb2.txt
cheers,
Gerd
next prev parent reply other threads:[~2020-02-14 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 6:21 [PATCH 1/3] hw: usb: hcd-ohci: Move OHCISysBusState and TYPE_SYSBUS_OHCI to include file Guenter Roeck
2020-02-14 6:21 ` [PATCH 2/3] arm: allwinner: Wire up USB OHCI Guenter Roeck
2020-02-14 6:21 ` [PATCH 3/3] arm: allwinner: Wire up USB EHCI Guenter Roeck
2020-02-14 10:08 ` Gerd Hoffmann [this message]
2020-02-14 14:26 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214100837.lv2cok5he7epmu7i@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=b.galvani@gmail.com \
--cc=linux@roeck-us.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).