From: "Ján Tomko" <jtomko@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 2/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment
Date: Sun, 16 Feb 2020 22:23:49 +0100 [thread overview]
Message-ID: <20200216212349.GC745061@lpt> (raw)
In-Reply-To: <20200215160716.1262-3-philmd@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1860 bytes --]
On Sat, Feb 15, 2020 at 05:07:15PM +0100, Philippe Mathieu-Daudé wrote:
>Fix warning reported by Clang static code analyzer:
>
> CC tools/virtiofsd/passthrough_ll.o
> tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to 'newfd' is never read
> newfd = -1;
> ^ ~~
> tools/virtiofsd/passthrough_ll.c:942:9: warning: Value stored to 'newfd' is never read
> newfd = -1;
> ^ ~~
>
>Fixes: 7c6b66027
>Reported-by: Clang Static Analyzer
>Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>---
> tools/virtiofsd/passthrough_ll.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
>index e9e71d5fc2..b38e0e4d84 100644
>--- a/tools/virtiofsd/passthrough_ll.c
>+++ b/tools/virtiofsd/passthrough_ll.c
>@@ -922,7 +922,6 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent, const char *name,
> inode = lo_find(lo, &e->attr);
> if (inode) {
> close(newfd);
>- newfd = -1;
> } else {
> inode = calloc(1, sizeof(struct lo_inode));
> if (!inode) {
>@@ -938,8 +937,7 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent, const char *name,
> g_atomic_int_set(&inode->refcount, 2);
>
> inode->nlookup = 1;
>- inode->fd = newfd;
>- newfd = -1;
>+ inode->fd = -1;
The functional equivalent is:
inode->fd = newfd;
newfd cannot contain -1 here, as checked a few lines above:
newfd = openat(dir->fd, name, O_PATH | O_NOFOLLOW);
if (newfd == -1) {
goto out_err;
}
Jano
> inode->key.ino = e->attr.st_ino;
> inode->key.dev = e->attr.st_dev;
> pthread_mutex_init(&inode->plock_mutex, NULL);
>--
>2.21.1
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-16 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 16:07 [PATCH 0/3] tools/virtiofsd: Fix warning reported by Clang static code analyzer Philippe Mathieu-Daudé
2020-02-15 16:07 ` [PATCH 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment Philippe Mathieu-Daudé
2020-02-16 21:19 ` Ján Tomko
2020-02-15 16:07 ` [PATCH 2/3] " Philippe Mathieu-Daudé
2020-02-16 21:23 ` Ján Tomko [this message]
2020-02-17 9:36 ` Philippe Mathieu-Daudé
2020-02-15 16:07 ` [PATCH 3/3] tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header.error value Philippe Mathieu-Daudé
2020-02-16 21:25 ` Ján Tomko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200216212349.GC745061@lpt \
--to=jtomko@redhat.com \
--cc=dgilbert@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).