On Fri, Feb 14, 2020 at 09:08:09PM +0100, Kevin Wolf wrote: >commit_populate() is a very short function and only called in a single >place. Its return value doesn't tell us whether an error happened while >reading or writing, which would be necessary for sending the right data >in the BLOCK_JOB_ERROR QMP event. > >Signed-off-by: Kevin Wolf >--- > block/commit.c | 28 ++++++---------------------- > 1 file changed, 6 insertions(+), 22 deletions(-) > Reviewed-by: Ján Tomko Jano