From: Peter Krempa <pkrempa@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: libvir-list@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH 0/3] Tighten qemu-img rules on missing backing format
Date: Mon, 24 Feb 2020 12:43:56 +0100 [thread overview]
Message-ID: <20200224114356.GD3296@andariel.pipo.sk> (raw)
In-Reply-To: <20200224110145.GB3296@andariel.pipo.sk>
On Mon, Feb 24, 2020 at 12:01:45 +0100, Peter Krempa wrote:
> On Sat, Feb 22, 2020 at 05:23:38 -0600, Eric Blake wrote:
[...]
> > libvirt HAS to use blockdev-open on the backing chain and supply a
> > backing format there, and thus has to probe images. If libvirt ever
> > probes differently than qemu, we are back to the potential
> > guest-visible data corruption or potential host CVEs.
>
> As I've elaborated in [1] I disagree with the host CVE part. The
[1] https://www.redhat.com/archives/libvir-list/2020-February/msg00624.html
> insecure part is not probing the format itself, but probing format AND
> using the backing file of the image if we probed format.
next prev parent reply other threads:[~2020-02-24 11:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 11:23 [PATCH 0/3] Tighten qemu-img rules on missing backing format Eric Blake
2020-02-22 11:23 ` [PATCH 1/3] iotests: Specify explicit backing format where sensible Eric Blake
2020-02-22 11:23 ` [PATCH 2/3] block: Add support to warn on backing file change without format Eric Blake
2020-02-22 11:23 ` [PATCH 3/3] qemu-img: Deprecate use of -b without -F Eric Blake
2020-02-24 11:38 ` Peter Krempa
2020-02-24 16:08 ` Eric Blake
2020-02-24 17:28 ` Peter Krempa
2020-02-24 11:01 ` [PATCH 0/3] Tighten qemu-img rules on missing backing format Peter Krempa
2020-02-24 11:43 ` Peter Krempa [this message]
2020-02-24 16:14 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224114356.GD3296@andariel.pipo.sk \
--to=pkrempa@redhat.com \
--cc=eblake@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).