From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E4BBC43331 for ; Wed, 25 Mar 2020 12:33:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFFAE2076A for ; Wed, 25 Mar 2020 12:33:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d8tKIWLx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFFAE2076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH5Dp-00007O-4X for qemu-devel@archiver.kernel.org; Wed, 25 Mar 2020 08:33:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48227) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH5D3-00089B-4n for qemu-devel@nongnu.org; Wed, 25 Mar 2020 08:32:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jH5D2-000466-4o for qemu-devel@nongnu.org; Wed, 25 Mar 2020 08:32:37 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:54400) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jH5D2-00045p-0i for qemu-devel@nongnu.org; Wed, 25 Mar 2020 08:32:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585139555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OZiaXi+eVp6uYzFHXztzlK4Fm4jhX4deJu6CEdrm8/g=; b=d8tKIWLxdBdoGdI2KE/gE5izvW6yY8s80zjuld+0Bsb4xd545dqHznGDJdDad98Rh/N4eW me7cEam3QmGClUjqz/SifrAI9jnxyUEoje6j8LNQDLFYcl13VJfnsWHO5eWZP3mP83oviJ Bv9G/F9HYsP5bNn50ORKqBejMm/JwA4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-262-O0pLfBc4P-yRS6kV8cX0Nw-1; Wed, 25 Mar 2020 08:32:34 -0400 X-MC-Unique: O0pLfBc4P-yRS6kV8cX0Nw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D47C18C43F4; Wed, 25 Mar 2020 12:32:26 +0000 (UTC) Received: from localhost (unknown [10.40.208.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id 468F7A0A85; Wed, 25 Mar 2020 12:32:13 +0000 (UTC) Date: Wed, 25 Mar 2020 13:32:12 +0100 From: Igor Mammedov To: Gerd Hoffmann Subject: Re: [PATCH 00/13] microvm: add acpi support Message-ID: <20200325133212.6fd0fefb@redhat.com> In-Reply-To: <20200319080117.7725-1-kraxel@redhat.com> References: <20200319080117.7725-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 19 Mar 2020 09:01:04 +0100 Gerd Hoffmann wrote: > I know that not supporting ACPI in microvm is intentional. If you still > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > switch to toggle ACPI support. > > These are the advantages you are going to loose then: > > (1) virtio-mmio device discovery without command line hacks (tweaking > the command line is a problem when not using direct kernel boot). > (2) Better IO-APIC support, we can use IRQ lines 16-23. > (3) ACPI power button (aka powerdown request) works. > (4) machine poweroff (aka S5 state) works. > > Together with seabios patches for virtio-mmio support this allows to > boot standard fedora images (cloud, coreos, workstation live) with the > microvm machine type. what CLI do you use to test it? > > cheers, > Gerd > > Gerd Hoffmann (13): > acpi: make build_madt() more generic. > acpi: factor out acpi_dsdt_add_fw_cfg() > microvm: add isa-acpi device > microvm: add minimal acpi support. > microvm: add acpi_dsdt_add_virtio() for x86 > microvm: disable virtio-mmio cmdline hack > [testing] seabios: update submodule to experimental microvm branch > [testing] seabios: update config & build rules > [testing] seabios: update binaries to experimental microvm branch > microvm/acpi: add rtc > microvm/acpi: add serial > microvm: make virtio irq base runtime configurable > microvm/acpi: use GSI 16-23 for virtio > > include/hw/i386/microvm.h | 8 +- > hw/acpi/isa-acpi.c | 114 +++++++++++++++ > hw/i386/acpi-build.c | 278 +++++++++++++++++++++++++++++------- > hw/i386/microvm.c | 32 +++-- > hw/acpi/Makefile.objs | 1 + > pc-bios/bios-256k.bin | Bin 262144 -> 262144 bytes > pc-bios/bios-microvm.bin | Bin 65536 -> 131072 bytes > pc-bios/bios.bin | Bin 131072 -> 131072 bytes > roms/Makefile | 5 +- > roms/config.seabios-128k | 2 + > roms/config.seabios-microvm | 25 ++++ > roms/seabios | 2 +- > 12 files changed, 403 insertions(+), 64 deletions(-) > create mode 100644 hw/acpi/isa-acpi.c > create mode 100644 roms/config.seabios-microvm >