From: Keith Busch <kbusch@kernel.org>
To: Andrzej Jakowski <andrzej.jakowski@linux.intel.com>
Cc: kwolf@redhat.com, haozhong.zhang@intel.com,
qemu-block@nongnu.org, stefanha@gmail.com, dgilbert@redhat.com,
qemu-devel@nongnu.org, yi.z.zhang@linux.intel.com,
junyan.he@intel.com, Stefan Hajnoczi <stefanha@redhat.com>,
Klaus Jensen <k.jensen@samsung.com>,
mreitz@redhat.com
Subject: Re: [PATCH RESEND v4] nvme: introduce PMR support from NVMe 1.4 spec
Date: Tue, 31 Mar 2020 01:55:18 +0900 [thread overview]
Message-ID: <20200330165518.GA8234@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20200330164656.9348-1-andrzej.jakowski@linux.intel.com>
On Mon, Mar 30, 2020 at 09:46:56AM -0700, Andrzej Jakowski wrote:
> This patch introduces support for PMR that has been defined as part of NVMe 1.4
> spec. User can now specify a pmrdev option that should point to HostMemoryBackend.
> pmrdev memory region will subsequently be exposed as PCI BAR 2 in emulated NVMe
> device. Guest OS can perform mmio read and writes to the PMR region that will stay
> persistent across system reboot.
Looks pretty good to me.
Reviewed-by: Keith Busch <kbusch@kernel.org>
For a possible future extention, it could be interesting to select the
BAR for PMR dynamically, so that you could have CMB and PMR enabled on
the same device.
next prev parent reply other threads:[~2020-03-30 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 16:46 [PATCH RESEND v4] nvme: introduce PMR support from NVMe 1.4 spec Andrzej Jakowski
2020-03-30 16:55 ` Keith Busch [this message]
2020-03-30 18:07 ` Klaus Birkelund Jensen
2020-03-30 18:13 ` Keith Busch
2020-03-30 19:31 ` Klaus Birkelund Jensen
2020-04-08 9:01 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330165518.GA8234@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=andrzej.jakowski@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=junyan.he@intel.com \
--cc=k.jensen@samsung.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
--cc=yi.z.zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).