From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA286C43331 for ; Tue, 31 Mar 2020 05:42:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78711206EB for ; Tue, 31 Mar 2020 05:42:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78711206EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJ9fI-0006mX-Ih for qemu-devel@archiver.kernel.org; Tue, 31 Mar 2020 01:42:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41052) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJ9cD-0001c7-Gd for qemu-devel@nongnu.org; Tue, 31 Mar 2020 01:39:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJ9cC-0001tZ-Iv for qemu-devel@nongnu.org; Tue, 31 Mar 2020 01:39:09 -0400 Received: from charlie.dont.surf ([128.199.63.193]:47950) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJ9cA-0001sO-Cj; Tue, 31 Mar 2020 01:39:06 -0400 Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by charlie.dont.surf (Postfix) with ESMTPSA id 4E9F8BF48F; Tue, 31 Mar 2020 05:39:05 +0000 (UTC) Date: Tue, 31 Mar 2020 07:39:01 +0200 From: Klaus Birkelund Jensen To: Maxim Levitsky Subject: Re: [PATCH v6 06/42] nvme: add identify cns values in header Message-ID: <20200331053901.mksyksmu54unox4x@apples.localdomain> References: <20200316142928.153431-1-its@irrelevant.dk> <20200316142928.153431-7-its@irrelevant.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 128.199.63.193 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Beata Michalska , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , Keith Busch , Javier Gonzalez Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mar 25 12:37, Maxim Levitsky wrote: > On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Signed-off-by: Klaus Jensen > > --- > > hw/block/nvme.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > > index f716f690a594..b38d7e548a60 100644 > > --- a/hw/block/nvme.c > > +++ b/hw/block/nvme.c > > @@ -709,11 +709,11 @@ static uint16_t nvme_identify(NvmeCtrl *n, NvmeCmd *cmd) > > NvmeIdentify *c = (NvmeIdentify *)cmd; > > > > switch (le32_to_cpu(c->cns)) { > > - case 0x00: > > + case NVME_ID_CNS_NS: > > return nvme_identify_ns(n, c); > > - case 0x01: > > + case NVME_ID_CNS_CTRL: > > return nvme_identify_ctrl(n, c); > > - case 0x02: > > + case NVME_ID_CNS_NS_ACTIVE_LIST: > > return nvme_identify_nslist(n, c); > > default: > > trace_nvme_dev_err_invalid_identify_cns(le32_to_cpu(c->cns)); > > This is a very good candidate to be squished with the patch 5 IMHO, > but you can leave this as is as well. I don't mind. > Squashed! > Reviewed-by: Maxim Levitsky > > Best regards, > Maxim Levitsky > > > > > >