qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"open list:Xilinx Zynq" <qemu-arm@nongnu.org>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: [PATCH-for-5.1 v2 41/54] hw/dma/xilinx_axidma: Add missing error-propagation code
Date: Mon,  6 Apr 2020 19:47:30 +0200	[thread overview]
Message-ID: <20200406174743.16956-42-f4bug@amsat.org> (raw)
In-Reply-To: <20200406174743.16956-1-f4bug@amsat.org>

Patch created mechanically by running:

  $ spatch \
    --macro-file scripts/cocci-macro-file.h --include-headers \
    --sp-file scripts/coccinelle/object_property_missing_error_propagate.cocci \
    --keep-comments --smpl-spacing --dir hw

Then review showed this file has a 'xilinx_axidma_realize_fail'
label that calls error_propagate().  Updated the patch to use
the label.

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
v2: New cocci patch generated both transformations
    (Peter noticed v1 only catched one)
---
 hw/dma/xilinx_axidma.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
index 018f36991b..2d36346319 100644
--- a/hw/dma/xilinx_axidma.c
+++ b/hw/dma/xilinx_axidma.c
@@ -531,6 +531,9 @@ static void xilinx_axidma_realize(DeviceState *dev, Error **errp)
                              object_property_allow_set_link,
                              OBJ_PROP_LINK_STRONG,
                              &local_err);
+    if (local_err) {
+        goto xilinx_axidma_realize_fail;
+    }
     object_property_add_link(OBJECT(cs), "dma", TYPE_XILINX_AXI_DMA,
                              (Object **)&cs->dma,
                              object_property_allow_set_link,
@@ -540,6 +543,9 @@ static void xilinx_axidma_realize(DeviceState *dev, Error **errp)
         goto xilinx_axidma_realize_fail;
     }
     object_property_set_link(OBJECT(ds), OBJECT(s), "dma", &local_err);
+    if (local_err) {
+        goto xilinx_axidma_realize_fail;
+    }
     object_property_set_link(OBJECT(cs), OBJECT(s), "dma", &local_err);
     if (local_err) {
         goto xilinx_axidma_realize_fail;
-- 
2.21.1



  parent reply	other threads:[~2020-04-06 18:23 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 17:46 [PATCH-for-5.1 v2 00/54] various: Fix error-propagation with Coccinelle scripts Philippe Mathieu-Daudé
2020-04-06 17:46 ` [PATCH-for-5.1 v2 01/54] various: Remove suspicious '\' character outside of #define in C code Philippe Mathieu-Daudé
2020-04-06 17:57   ` Marc-André Lureau
2020-04-06 17:46 ` [PATCH-for-5.1 v2 02/54] scripts/coccinelle: Script to simplify DeviceClass error propagation Philippe Mathieu-Daudé
2020-04-06 17:46 ` [PATCH-for-5.1 v2 03/54] hw/arm/allwinner-a10: Move some code from realize() to init() Philippe Mathieu-Daudé
2020-04-06 18:00   ` Eric Blake
2020-04-12 22:28     ` Philippe Mathieu-Daudé
2020-04-06 17:46 ` [PATCH-for-5.1 v2 04/54] hw/arm/aspeed_ast2600: Simplify use of Error* Philippe Mathieu-Daudé
2020-04-07  6:46   ` Cédric Le Goater
2020-04-06 17:46 ` [PATCH-for-5.1 v2 05/54] hw/arm/aspeed_ast2600: Move some code from realize() to init() Philippe Mathieu-Daudé
2020-04-06 17:46 ` [PATCH-for-5.1 v2 06/54] hw/arm/aspeed_soc: " Philippe Mathieu-Daudé
2020-04-07  6:47   ` Cédric Le Goater
2020-04-06 17:46 ` [PATCH-for-5.1 v2 07/54] hw/arm/aspeed_soc: Simplify use of Error* Philippe Mathieu-Daudé
2020-04-07  6:47   ` Cédric Le Goater
2020-04-06 17:46 ` [PATCH-for-5.1 v2 08/54] hw/arm/fsl-imx6: Simplify checks on 'smp_cpus' count Philippe Mathieu-Daudé
2020-04-06 17:46 ` [PATCH-for-5.1 v2 09/54] hw/arm/fsl-imx6: Move some code from realize() to init() Philippe Mathieu-Daudé
2020-04-06 17:46 ` [PATCH-for-5.1 v2 10/54] hw/arm/fsl-imx31: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 11/54] hw/arm/msf2-soc: Store MemoryRegion in MSF2State Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 12/54] hw/arm/stm32f205_soc: Store MemoryRegion in STM32F205State Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 13/54] hw/arm/stm32f205_soc: Move some code from realize() to init() Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 14/54] hw/arm/xlnx-zynqmp: Use single propagate_error() call Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 15/54] hw/arm/xlnx-zynqmp: Split xlnx_zynqmp_create_rpu() as init + realize Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 16/54] hw/arm/xlnx-zynqmp: Move some code from realize() to init() Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 17/54] hw/microblaze/xlnx-zynqmp-pmu: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 18/54] hw/pci-host/pnv_phb3: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 19/54] hw/riscv/sifive_e: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 20/54] hw/riscv/sifive_u: Use single type_init() Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 21/54] hw/riscv/sifive_u: Move some code from realize() to init() Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 22/54] hw/riscv/sifive_u: Store MemoryRegion in SiFiveUSoCState Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 23/54] hw/riscv/sifive_u: Move some code from realize() to init() Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 24/54] hw/riscv/sifive_u: Rename MachineClass::init() Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 25/54] scripts/coccinelle: Catch missing error_propagate() calls in realize() Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 26/54] hw/arm/fsl-imx: Add missing error-propagation code Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 27/54] hw/arm/stm32f*05_soc: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 28/54] hw/arm/aspeed: " Philippe Mathieu-Daudé
2020-04-07  6:47   ` Cédric Le Goater
2020-04-06 17:47 ` [PATCH-for-5.1 v2 29/54] hw/arm/allwinner-a10: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 30/54] hw/arm/msf2-soc: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 31/54] hw/riscv/sifive: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 32/54] hw/arm/armv7m: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 33/54] hw/intc/arm_gicv3_its_kvm: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 34/54] hw/microblaze/xlnx-zynqmp-pmu: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 35/54] hw/pci-host/pnv_phb3: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 36/54] hw/block/onenand: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 37/54] scripts/coccinelle: Add script to catch missing error_propagate() calls Philippe Mathieu-Daudé
2020-04-06 20:06   ` Eric Blake
2020-04-06 17:47 ` [PATCH-for-5.1 v2 38/54] hw/arm/bcm2835_peripherals: Add missing error-propagation code Philippe Mathieu-Daudé
2020-04-06 17:55   ` Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 39/54] hw/arm/fsl-imx: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 40/54] hw/arm/stm32fx05_soc: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` Philippe Mathieu-Daudé [this message]
2020-04-06 17:47 ` [PATCH-for-5.1 v2 42/54] hw/i386/x86: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 43/54] hw/mips/cps: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 44/54] hw/misc/macio/macio: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 45/54] hw/net/xilinx_axienet: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 46/54] hw/riscv/sifive_u: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 47/54] hw/sd/milkymist-memcard: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 48/54] scripts/coccinelle: Use &error_abort in TypeInfo::instance_init() Philippe Mathieu-Daudé
2020-04-07  7:07   ` Vladimir Sementsov-Ogievskiy
2020-04-07 11:03     ` Philippe Mathieu-Daudé
2020-04-07 13:01       ` Vladimir Sementsov-Ogievskiy
2020-04-07 13:07         ` Philippe Mathieu-Daudé
2020-04-07 17:27           ` Philippe Mathieu-Daudé
2020-04-07 17:54             ` Vladimir Sementsov-Ogievskiy
2020-04-07 18:16               ` Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 49/54] various: Use &error_abort in instance_init() Philippe Mathieu-Daudé
2020-04-06 18:19   ` Philippe Mathieu-Daudé
2020-04-07  6:47   ` Cédric Le Goater
2020-04-07 13:27   ` Cornelia Huck
2020-04-06 17:47 ` [PATCH-for-5.1 v2 50/54] scripts/coccinelle: Find eventually missing error_propagate() calls Philippe Mathieu-Daudé
2020-04-07  7:15   ` Vladimir Sementsov-Ogievskiy
2020-04-06 17:47 ` [PATCH-for-5.1 v2 51/54] migration/colo: Add missing error-propagation code Philippe Mathieu-Daudé
2020-04-07  7:10   ` Juan Quintela
2020-04-06 17:47 ` [PATCH-for-5.1 v2 52/54] hw/mips/boston: " Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 53/54] hw/mips/mips_malta: " Philippe Mathieu-Daudé
2020-04-06 19:27   ` Philippe Mathieu-Daudé
2020-04-07 18:36   ` Richard Henderson
2020-04-12 22:28     ` Philippe Mathieu-Daudé
2020-04-06 17:47 ` [PATCH-for-5.1 v2 54/54] qga/commands-win32: " Philippe Mathieu-Daudé
2020-04-06 20:34 ` [PATCH-for-5.1 v2 00/54] various: Fix error-propagation with Coccinelle scripts no-reply
2020-04-06 20:39 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200406174743.16956-42-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=alistair.francis@wdc.com \
    --cc=alistair@alistair23.me \
    --cc=armbru@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).