From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EE22C2BA19 for ; Mon, 13 Apr 2020 06:06:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D702520731 for ; Mon, 13 Apr 2020 06:06:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D702520731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNsEi-0001l6-3G for qemu-devel@archiver.kernel.org; Mon, 13 Apr 2020 02:06:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57878) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNsDg-0000OT-EI for qemu-devel@nongnu.org; Mon, 13 Apr 2020 02:05:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNsDf-0001WD-5q for qemu-devel@nongnu.org; Mon, 13 Apr 2020 02:05:20 -0400 Received: from mga09.intel.com ([134.134.136.24]:11040) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jNsDe-0001Vs-Ua for qemu-devel@nongnu.org; Mon, 13 Apr 2020 02:05:19 -0400 IronPort-SDR: lF6U5BX3AUJpKrqgfu2mQ8U1ge/siY1ydJIu7xF1a2QPZC2vlX9txCOkpT+1hvxMFcTxgUTebh DwaHjotvGRjQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2020 23:05:17 -0700 IronPort-SDR: roeKVt03RrchyMNuA8CrXSyOrbiZ5X+JKJ9kqReJE3JUUjKofhNcZ7rvaWNpS8f5VdpZlMviVm 2Are1mH2PCgw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,377,1580803200"; d="scan'208";a="245065924" Received: from joy-optiplex-7040.sh.intel.com ([10.239.13.16]) by fmsmga008.fm.intel.com with ESMTP; 12 Apr 2020 23:05:10 -0700 From: Yan Zhao To: intel-gvt-dev@lists.freedesktop.org Subject: [PATCH v5 4/4] drm/i915/gvt: export migration_version to mdev sysfs (under mdev device node) Date: Mon, 13 Apr 2020 01:55:32 -0400 Message-Id: <20200413055532.27363-1-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200413055201.27053-1-yan.y.zhao@intel.com> References: <20200413055201.27053-1-yan.y.zhao@intel.com> X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 134.134.136.24 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cjia@nvidia.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, libvir-list@redhat.com, Zhengxiao.zx@alibaba-inc.com, shuangtai.tst@alibaba-inc.com, qemu-devel@nongnu.org, kwankhede@nvidia.com, eauger@redhat.com, corbet@lwn.net, yi.l.liu@intel.com, eskultet@redhat.com, ziye.yang@intel.com, mlevitsk@redhat.com, pasic@linux.ibm.com, aik@ozlabs.ru, felipe@nutanix.com, Ken.Xue@amd.com, kevin.tian@intel.com, Yan Zhao , xin.zeng@intel.com, dgilbert@redhat.com, zhenyuw@linux.intel.com, dinechin@redhat.com, alex.williamson@redhat.com, changpeng.liu@intel.com, berrange@redhat.com, cohuck@redhat.com, linux-kernel@vger.kernel.org, zhi.a.wang@intel.com, jonathan.davies@nutanix.com, shaopeng.he@intel.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" mdev device par of migration_version attribute for Intel vGPU is rw. It is located at /sys/bus/pci/devices/0000\:00\:02.0/$mdev_UUID/migration_version, or /sys/bus/mdev/devices/$mdev_UUID/migration_version It's used to check migration compatibility for two vGPUs. migration_version string is defined by vendor driver and opaque to userspace. For Intel vGPU of gen8 and gen9, the format of migration_version string is: ---. For future software versions, e.g. when vGPUs have aggregations, it may also include aggregation count into migration_version string of a vGPU. For future platforms, the format of migration_version string is to be expanded to include more meta data to identify Intel vGPUs for live migration compatibility check For old platforms, and for GVT not supporting vGPU live migration feature, -ENODEV is returned on read(2)/write(2) of migration_version attribute. For vGPUs running old GVT who do not expose migration_version attribute, live migration is regarded as not supported for those vGPUs. Cc: Alex Williamson Cc: Erik Skultety Cc: "Dr. David Alan Gilbert" Cc: Cornelia Huck Cc: "Tian, Kevin" Cc: Zhenyu Wang Cc: "Wang, Zhi A" c: Neo Jia Cc: Kirti Wankhede Signed-off-by: Yan Zhao --- drivers/gpu/drm/i915/gvt/gvt.h | 2 ++ drivers/gpu/drm/i915/gvt/kvmgt.c | 55 ++++++++++++++++++++++++++++++++ 2 files changed, 57 insertions(+) diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h index b26e42596565..664efc83f82e 100644 --- a/drivers/gpu/drm/i915/gvt/gvt.h +++ b/drivers/gpu/drm/i915/gvt/gvt.h @@ -205,6 +205,8 @@ struct intel_vgpu { struct idr object_idr; u32 scan_nonprivbb; + + char *migration_version; }; static inline void *intel_vgpu_vdev(struct intel_vgpu *vgpu) diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c index 2f2d4c40f966..4903599cb0ef 100644 --- a/drivers/gpu/drm/i915/gvt/kvmgt.c +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c @@ -728,8 +728,13 @@ static int intel_vgpu_create(struct kobject *kobj, struct mdev_device *mdev) kvmgt_vdev(vgpu)->mdev = mdev; mdev_set_drvdata(mdev, vgpu); + vgpu->migration_version = + intel_gvt_get_vfio_migration_version(gvt, type->name); + gvt_dbg_core("intel_vgpu_create succeeded for mdev: %s\n", dev_name(mdev_dev(mdev))); + + ret = 0; out: @@ -744,6 +749,7 @@ static int intel_vgpu_remove(struct mdev_device *mdev) return -EBUSY; intel_gvt_ops->vgpu_destroy(vgpu); + kfree(vgpu->migration_version); return 0; } @@ -1964,8 +1970,57 @@ static const struct attribute_group intel_vgpu_group = { .attrs = intel_vgpu_attrs, }; +static ssize_t migration_version_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct mdev_device *mdev = mdev_from_dev(dev); + struct intel_vgpu *vgpu = mdev_get_drvdata(mdev); + + if (!vgpu->migration_version) { + gvt_vgpu_err("Migration not supported on this vgpu. Please search previous detailed log\n"); + return -ENODEV; + } + + return snprintf(buf, strlen(vgpu->migration_version) + 2, + "%s\n", vgpu->migration_version); + +} + +static ssize_t migration_version_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct mdev_device *mdev = mdev_from_dev(dev); + struct intel_vgpu *vgpu = mdev_get_drvdata(mdev); + struct intel_gvt *gvt = vgpu->gvt; + int ret = 0; + + if (!vgpu->migration_version) { + gvt_vgpu_err("Migration not supported on this vgpu. Please search previous detailed log\n"); + return -ENODEV; + } + + ret = intel_gvt_check_vfio_migration_version(gvt, + vgpu->migration_version, buf); + return (ret < 0 ? ret : count); +} + +static DEVICE_ATTR_RW(migration_version); + +static struct attribute *intel_vgpu_migration_attrs[] = { + &dev_attr_migration_version.attr, + NULL, +}; +/* this group has no name, so will be displayed + * immediately under sysfs node of the mdev device + */ +static const struct attribute_group intel_vgpu_group_empty_name = { + .attrs = intel_vgpu_migration_attrs, +}; + static const struct attribute_group *intel_vgpu_groups[] = { &intel_vgpu_group, + &intel_vgpu_group_empty_name, NULL, }; -- 2.17.1