From: Sergei Trofimovich <slyfox@gentoo.org>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output
Date: Thu, 30 Apr 2020 23:59:34 +0100 [thread overview]
Message-ID: <20200430235934.210904e7@sf> (raw)
In-Reply-To: <20200416175957.1274882-1-slyfox@gentoo.org>
On Thu, 16 Apr 2020 18:59:57 +0100
Sergei Trofimovich <slyfox@gentoo.org> wrote:
> Fix syscall name and parameters priinter.
>
> Before the change:
>
> ```
> $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a
> ...
> 1274697 %s(%d)(2097152,274903156744,274903156760,274905840712,274877908880,274903235616) = 3
> 1274697 exit_group(0)
> ```
>
> After the change:
>
> ```
> $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a
> ...
> 1273719 epoll_create1(2097152) = 3
> 1273719 exit_group(0)
> ```
>
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> CC: Riku Voipio <riku.voipio@iki.fi>
> CC: Laurent Vivier <laurent@vivier.eu>
> ---
> linux-user/strace.list | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index d49a1e92a8..9281c0a758 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -125,10 +125,10 @@
> { TARGET_NR_dup3, "dup3" , "%s(%d,%d,%d)", NULL, NULL },
> #endif
> #ifdef TARGET_NR_epoll_create
> -{ TARGET_NR_epoll_create, "%s(%d)", NULL, NULL, NULL },
> +{ TARGET_NR_epoll_create, "epoll_create", "%s(%d)", NULL, NULL },
> #endif
> #ifdef TARGET_NR_epoll_create1
> -{ TARGET_NR_epoll_create1, "%s(%d)", NULL, NULL, NULL },
> +{ TARGET_NR_epoll_create1, "epoll_create1", "%s(%d)", NULL, NULL },
> #endif
> #ifdef TARGET_NR_epoll_ctl
> { TARGET_NR_epoll_ctl, "epoll_ctl" , NULL, NULL, NULL },
> --
> 2.26.1
>
Should it be handled differently?
--
Sergei
next prev parent reply other threads:[~2020-04-30 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 17:59 [PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output Sergei Trofimovich
2020-04-30 22:59 ` Sergei Trofimovich [this message]
2020-05-01 15:06 ` Philippe Mathieu-Daudé
2020-05-27 14:39 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430235934.210904e7@sf \
--to=slyfox@gentoo.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).