From: P J P <ppandit@redhat.com>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>,
Prasad J Pandit <pjp@fedoraproject.org>,
Ren Ding <rding@gatech.edu>
Subject: [PATCH 1/2] megasas: use unsigned type for reply_queue_head
Date: Thu, 7 May 2020 16:27:17 +0530 [thread overview]
Message-ID: <20200507105718.1319187-2-ppandit@redhat.com> (raw)
In-Reply-To: <20200507105718.1319187-1-ppandit@redhat.com>
From: Prasad J Pandit <pjp@fedoraproject.org>
A guest user may set 's->reply_queue_head' MegasasState field to
a negative value. Later in 'megasas_lookup_frame' it is used to
index into s->frames[] array. Use unsigned type to avoid OOB
access issue.
Reported-by: Ren Ding <rding@gatech.edu>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
hw/scsi/megasas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index af18c88b65..433353bad0 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -112,7 +112,7 @@ typedef struct MegasasState {
uint64_t reply_queue_pa;
void *reply_queue;
int reply_queue_len;
- int reply_queue_head;
+ uint16_t reply_queue_head;
int reply_queue_tail;
uint64_t consumer_pa;
uint64_t producer_pa;
--
2.25.4
next prev parent reply other threads:[~2020-05-07 11:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 10:57 [PATCH 0/2] use unsigned type for MegasasState fields P J P
2020-05-07 10:57 ` P J P [this message]
2020-05-12 18:52 ` [PATCH 1/2] megasas: use unsigned type for reply_queue_head Peter Maydell
2020-05-13 11:20 ` P J P
2020-05-07 10:57 ` [PATCH 2/2] megasas: use unsigned type for positive numeric fields P J P
2020-05-12 18:53 ` Peter Maydell
2020-05-13 11:22 ` P J P
2020-05-12 12:21 ` [PATCH 0/2] use unsigned type for MegasasState fields P J P
2020-05-12 13:42 ` Philippe Mathieu-Daudé
2020-05-12 18:37 ` P J P
2020-05-12 19:08 ` Alexander Bulekov
2020-05-12 19:48 ` Alexander Bulekov
2020-05-12 20:59 ` Philippe Mathieu-Daudé
2020-05-12 21:00 ` Alexander Bulekov
2020-05-13 11:13 ` P J P
2020-05-13 13:49 ` P J P
2020-05-13 14:20 ` Alexander Bulekov
2020-05-13 14:53 ` P J P
2020-05-13 17:08 ` Ding, Ren
2020-05-13 19:34 ` P J P
2020-05-13 14:53 ` Alexander Bulekov
[not found] ` <BN6PR07MB341283EBBF78F86AAA995382CABE0@BN6PR07MB3412.namprd07.prod.outlook.com>
2020-05-12 20:54 ` 回复: " Philippe Mathieu-Daudé
2020-05-13 11:07 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507105718.1319187-2-ppandit@redhat.com \
--to=ppandit@redhat.com \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=qemu-devel@nongnu.org \
--cc=rding@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).