From: Gerd Hoffmann <kraxel@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Sergio Lopez <slp@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v2 09/13] microvm: add minimal acpi support
Date: Thu, 7 May 2020 15:39:30 +0200 [thread overview]
Message-ID: <20200507133930.dzioq37pbujf5c3a@sirius.home.kraxel.org> (raw)
In-Reply-To: <20200506161419.3d17e26a@redhat.com>
On Wed, May 06, 2020 at 04:14:19PM +0200, Igor Mammedov wrote:
> On Wed, 6 May 2020 12:35:49 +0200
> Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> > > > +/* FIXME: copy & paste */
> > > > +static void acpi_dsdt_add_power_button(Aml *scope)
> > > > +{
> > > > + Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE);
> > > > + aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C")));
> > > > + aml_append(dev, aml_name_decl("_UID", aml_int(0)));
> > > > + aml_append(scope, dev);
> > > > +}
> > >
> > > could be unified with ARM's version
> >
> > Yep. Suggestions for a good place? hw/acpi/aml-build.c ?
> sounds good to me
Hmm, tried that, but ACPI_POWER_BUTTON_DEVICE is defined in ged header
file, so ged.c looks like a better fit ;)
take care,
Gerd
next prev parent reply other threads:[~2020-05-07 13:40 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 13:42 [PATCH v2 00/13] microvm: add acpi support Gerd Hoffmann
2020-05-05 13:42 ` [PATCH v2 01/13] acpi: make build_madt() more generic Gerd Hoffmann
2020-05-05 13:54 ` Igor Mammedov
2020-05-05 13:42 ` [PATCH v2 02/13] acpi: create acpi-common.c and move madt code Gerd Hoffmann
2020-05-05 14:00 ` Igor Mammedov
2020-05-05 13:42 ` [PATCH v2 03/13] acpi: madt: skip pci override on pci-less systems (microvm) Gerd Hoffmann
2020-05-05 14:10 ` Igor Mammedov
2020-05-05 14:17 ` Philippe Mathieu-Daudé
2020-05-05 13:42 ` [PATCH v2 04/13] acpi: move acpi_build_facs to acpi-common.c Gerd Hoffmann
2020-05-05 13:49 ` Philippe Mathieu-Daudé
2020-05-05 14:16 ` Igor Mammedov
2020-05-05 13:42 ` [PATCH v2 05/13] acpi: move acpi_init_common_fadt_data " Gerd Hoffmann
2020-05-05 14:25 ` Igor Mammedov
2020-05-06 10:03 ` Gerd Hoffmann
2020-05-05 13:42 ` [PATCH v2 06/13] acpi: move acpi_align_size to acpi-common.h Gerd Hoffmann
2020-05-05 13:53 ` Philippe Mathieu-Daudé
2020-05-05 14:30 ` Igor Mammedov
2020-05-05 13:42 ` [PATCH v2 07/13] acpi: fadt: add hw-reduced sleep register support Gerd Hoffmann
2020-05-05 14:35 ` Igor Mammedov
2020-05-05 13:43 ` [PATCH v2 08/13] acpi: generic event device for x86 Gerd Hoffmann
2020-05-05 15:03 ` Igor Mammedov
2020-05-06 10:31 ` Gerd Hoffmann
2020-05-06 12:41 ` Igor Mammedov
2020-05-07 14:03 ` Gerd Hoffmann
2020-05-05 13:43 ` [PATCH v2 09/13] microvm: add minimal acpi support Gerd Hoffmann
2020-05-05 15:20 ` Igor Mammedov
2020-05-06 10:35 ` Gerd Hoffmann
2020-05-06 14:14 ` Igor Mammedov
2020-05-07 13:39 ` Gerd Hoffmann [this message]
2020-05-05 13:43 ` [PATCH v2 10/13] microvm: disable virtio-mmio cmdline hack Gerd Hoffmann
2020-05-05 15:22 ` Igor Mammedov
2020-05-05 13:43 ` [PATCH v2 11/13] microvm: add acpi_dsdt_add_virtio() for x86 Gerd Hoffmann
2020-05-06 7:27 ` Sergio Lopez
2020-05-05 13:43 ` [PATCH v2 12/13] microvm: make virtio irq base runtime configurable Gerd Hoffmann
2020-05-06 7:28 ` Sergio Lopez
2020-05-05 13:43 ` [PATCH v2 13/13] microvm/acpi: use GSI 16-23 for virtio Gerd Hoffmann
2020-05-06 7:28 ` Sergio Lopez
2020-05-05 14:04 ` [PATCH v2 00/13] microvm: add acpi support Michael S. Tsirkin
2020-05-05 14:16 ` Philippe Mathieu-Daudé
2020-05-06 7:25 ` Sergio Lopez
2020-05-06 11:46 ` Gerd Hoffmann
2020-05-06 11:50 ` Michael S. Tsirkin
2020-05-07 13:57 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507133930.dzioq37pbujf5c3a@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).