From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org,
Hailiang Zhang <zhang.zhanghailiang@huawei.com>
Subject: Re: [PATCH-for-5.1 v3 4/7] migration/colo: Add missing error-propagation code
Date: Thu, 7 May 2020 16:26:51 +0100 [thread overview]
Message-ID: <20200507152651.GD17348@work-vm> (raw)
In-Reply-To: <20200413205250.687-1-f4bug@amsat.org>
* Philippe Mathieu-Daudé (f4bug@amsat.org) wrote:
> Running the coccinelle script produced:
>
> $ spatch \
> --macro-file scripts/cocci-macro-file.h --include-headers \
> --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \
> --keep-comments --smpl-spacing --dir .
> HANDLING: ./migration/colo.c
> [[manual check required: error_propagate() might be missing in migrate_set_block_enabled() ./migration/colo.c:439:4]]
>
> Add the missing error_propagate() after review.
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Queued this entry for migration
> ---
> migration/colo.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/migration/colo.c b/migration/colo.c
> index a54ac84f41..57b2adb0cc 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -437,6 +437,9 @@ static int colo_do_checkpoint_transaction(MigrationState *s,
>
> /* Disable block migration */
> migrate_set_block_enabled(false, &local_err);
> + if (local_err) {
> + goto out;
> + }
> qemu_mutex_lock_iothread();
>
> #ifdef CONFIG_REPLICATION
> --
> 2.21.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2020-05-07 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 20:52 [PATCH-for-5.1 v3 4/7] migration/colo: Add missing error-propagation code Philippe Mathieu-Daudé
2020-04-13 20:52 ` [PATCH-for-5.1 v3 5/7] hw/mips/boston: " Philippe Mathieu-Daudé
2020-04-29 6:38 ` Markus Armbruster
2020-05-07 15:26 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507152651.GD17348@work-vm \
--to=dgilbert@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).