From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, s.reiter@proxmox.com,
armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com,
t.lamprecht@proxmox.com
Subject: [RFC PATCH 3/3] block: Assert we're running in the right thread
Date: Tue, 12 May 2020 16:43:18 +0200 [thread overview]
Message-ID: <20200512144318.181049-4-kwolf@redhat.com> (raw)
In-Reply-To: <20200512144318.181049-1-kwolf@redhat.com>
tracked_request_begin() is called for most I/O operations, so it's a
good place to assert that we're indeed running in the home thread of the
node's AioContext.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/io.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/block/io.c b/block/io.c
index 7808e8bdc0..924bf5ba46 100644
--- a/block/io.c
+++ b/block/io.c
@@ -695,14 +695,17 @@ static void tracked_request_begin(BdrvTrackedRequest *req,
uint64_t bytes,
enum BdrvTrackedRequestType type)
{
+ Coroutine *self = qemu_coroutine_self();
+
assert(bytes <= INT64_MAX && offset <= INT64_MAX - bytes);
+ assert(bs->aio_context == qemu_coroutine_get_aio_context(self));
*req = (BdrvTrackedRequest){
.bs = bs,
.offset = offset,
.bytes = bytes,
.type = type,
- .co = qemu_coroutine_self(),
+ .co = self,
.serialising = false,
.overlap_offset = offset,
.overlap_bytes = bytes,
--
2.25.3
next prev parent reply other threads:[~2020-05-12 14:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 14:43 [RFC PATCH 0/3] block: Synchronous bdrv_*() from coroutine in different AioContext Kevin Wolf
2020-05-12 14:43 ` [RFC PATCH 1/3] block: Factor out bdrv_run_co() Kevin Wolf
2020-05-12 15:37 ` Eric Blake
2020-05-20 9:09 ` Philippe Mathieu-Daudé
2020-05-20 11:14 ` Vladimir Sementsov-Ogievskiy
2020-05-12 14:43 ` [RFC PATCH 2/3] block: Allow bdrv_run_co() from different AioContext Kevin Wolf
2020-05-12 16:02 ` Thomas Lamprecht
2020-05-12 19:29 ` Kevin Wolf
2020-05-25 14:18 ` Stefan Reiter
2020-05-25 16:41 ` Kevin Wolf
2020-05-26 16:42 ` Kevin Wolf
2020-05-27 8:56 ` Stefan Reiter
2020-05-12 14:43 ` Kevin Wolf [this message]
2020-05-14 13:52 ` [RFC PATCH 3/3] block: Assert we're running in the right thread Stefan Reiter
2020-05-14 14:30 ` Kevin Wolf
2020-05-20 9:12 ` Philippe Mathieu-Daudé
2020-05-14 13:21 ` [RFC PATCH 0/3] block: Synchronous bdrv_*() from coroutine in different AioContext Thomas Lamprecht
2020-05-14 14:26 ` Kevin Wolf
2020-05-19 12:32 ` Vladimir Sementsov-Ogievskiy
2020-05-19 13:54 ` Denis Plotnikov
2020-05-19 14:18 ` Kevin Wolf
2020-05-19 15:05 ` Denis Plotnikov
2020-05-19 15:29 ` Kevin Wolf
2020-05-19 15:48 ` Vladimir Sementsov-Ogievskiy
2020-05-19 16:06 ` Eric Blake
2020-05-20 7:23 ` Denis Plotnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512144318.181049-4-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=s.reiter@proxmox.com \
--cc=stefanha@redhat.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).