From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AA22C5321B for ; Tue, 12 May 2020 15:37:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC86F206DD for ; Tue, 12 May 2020 15:37:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GCyd69Sl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC86F206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYWy7-0005mQ-1l for qemu-devel@archiver.kernel.org; Tue, 12 May 2020 11:37:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYWWg-0000A2-Tf for qemu-devel@nongnu.org; Tue, 12 May 2020 11:08:58 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:28506 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jYWWf-0004bH-W0 for qemu-devel@nongnu.org; Tue, 12 May 2020 11:08:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589296137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oxXSMrOEchlImeEnuCjdXjbQEH5AKvytZXt9+F8uSRM=; b=GCyd69SlEGlbyw4PMlUa7589NUMAsG8thU+Yktcj1uTCCFgA0dA8GvBGiLmdKxtKh+fStG CjKeaV+1koquIKwY4JK5IGU1i3j6vwYo89DxU6/RoZoa4m0HLn6/cfblV0eWRZqrJEn4dw vIllp/d5/U2Q4UeqzrO5tjcdgBqq5Ac= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-InOx64K3MMqmOJ7hyCJVOA-1; Tue, 12 May 2020 11:08:55 -0400 X-MC-Unique: InOx64K3MMqmOJ7hyCJVOA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3F22B473; Tue, 12 May 2020 15:08:54 +0000 (UTC) Received: from localhost (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8FADA10001B3; Tue, 12 May 2020 15:08:39 +0000 (UTC) Date: Tue, 12 May 2020 17:08:34 +0200 From: Igor Mammedov To: Gerd Hoffmann Subject: Re: [PATCH v5 13/15] acpi: drop build_piix4_pm() Message-ID: <20200512170834.29eab76c@redhat.com> In-Reply-To: <20200512111605.w5guklhowx3uufss@sirius.home.kraxel.org> References: <20200507131640.14041-1-kraxel@redhat.com> <20200507131640.14041-14-kraxel@redhat.com> <20200511213732.4f540923@redhat.com> <20200512111605.w5guklhowx3uufss@sirius.home.kraxel.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/12 02:02:05 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Kevin Wolf , Thomas Huth , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Max Reitz , Paolo Bonzini , =?UTF-8?B?TWFyYy1BbmRy?= =?UTF-8?B?w6k=?= Lureau , John Snow , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 12 May 2020 13:16:05 +0200 Gerd Hoffmann wrote: > On Mon, May 11, 2020 at 09:37:32PM +0200, Igor Mammedov wrote: > > On Thu, 7 May 2020 15:16:38 +0200 > > Gerd Hoffmann wrote: > > > > > The _SB.PCI0.PX13.P13C opregion (holds isa device enable bits) > > > is not used any more, remove it from DSDT. > > > > > > Signed-off-by: Gerd Hoffmann > > > --- > > > hw/i386/acpi-build.c | 16 ---------------- > > > 1 file changed, 16 deletions(-) > > > > > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > > > index 765409a90eb6..c1e63cce5e8e 100644 > > > --- a/hw/i386/acpi-build.c > > > +++ b/hw/i386/acpi-build.c > > > @@ -1441,21 +1441,6 @@ static void build_q35_isa_bridge(Aml *table) > > > aml_append(table, scope); > > > } > > > > > > -static void build_piix4_pm(Aml *table) > > > -{ > > > - Aml *dev; > > > - Aml *scope; > > > - > > > - scope = aml_scope("_SB.PCI0"); > > > - dev = aml_device("PX13"); > > > - aml_append(dev, aml_name_decl("_ADR", aml_int(0x00010003))); > > I agree about removing P13C but I'm not sure if it's safe to remove > > whole isa bridge > > The isa bridge is _SB0.PCI0.ISA (piix4 function 0). > _SB.PCI0.PX13 is the acpi pm device (piix4 function 3). > > So this does _not_ remove the isa bridge. And given that PX13 has > nothing declared beside the opregion we are removing and I have not > found any other references to the PX13 device I assumed it is ok to drop > that one too. Didn't notice any odd side effects in testing. I don't see HID or some other way to tell guest that it should load a driver for it so probably we can remove it. If it breaks some legacy OS we can always add it back. > > take care, > Gerd >