qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH  v1 2/8] qemu/plugin: Move !CONFIG_PLUGIN stubs altogether
Date: Wed, 13 May 2020 18:31:54 +0100	[thread overview]
Message-ID: <20200513173200.11830-3-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200513173200.11830-1-alex.bennee@linaro.org>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Simplify the ifdef'ry by moving all stubs together.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200510171119.20827-3-f4bug@amsat.org>
---
 include/qemu/plugin.h | 33 +++++++++++++++------------------
 1 file changed, 15 insertions(+), 18 deletions(-)

diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h
index e45f950fe36..ab790ad105c 100644
--- a/include/qemu/plugin.h
+++ b/include/qemu/plugin.h
@@ -46,22 +46,6 @@ static inline void qemu_plugin_add_opts(void)
 
 void qemu_plugin_opt_parse(const char *optarg, QemuPluginList *head);
 int qemu_plugin_load_list(QemuPluginList *head);
-#else /* !CONFIG_PLUGIN */
-static inline void qemu_plugin_add_opts(void)
-{ }
-
-static inline void qemu_plugin_opt_parse(const char *optarg,
-                                         QemuPluginList *head)
-{
-    error_report("plugin interface not enabled in this build");
-    exit(1);
-}
-
-static inline int qemu_plugin_load_list(QemuPluginList *head)
-{
-    return 0;
-}
-#endif /* !CONFIG_PLUGIN */
 
 union qemu_plugin_cb_sig {
     qemu_plugin_simple_cb_t          simple;
@@ -182,8 +166,6 @@ struct qemu_plugin_insn *qemu_plugin_tb_insn_get(struct qemu_plugin_tb *tb)
     return insn;
 }
 
-#ifdef CONFIG_PLUGIN
-
 void qemu_plugin_vcpu_init_hook(CPUState *cpu);
 void qemu_plugin_vcpu_exit_hook(CPUState *cpu);
 void qemu_plugin_tb_trans_cb(CPUState *cpu, struct qemu_plugin_tb *tb);
@@ -207,6 +189,21 @@ void qemu_plugin_disable_mem_helpers(CPUState *cpu);
 
 #else /* !CONFIG_PLUGIN */
 
+static inline void qemu_plugin_add_opts(void)
+{ }
+
+static inline void qemu_plugin_opt_parse(const char *optarg,
+                                         QemuPluginList *head)
+{
+    error_report("plugin interface not enabled in this build");
+    exit(1);
+}
+
+static inline int qemu_plugin_load_list(QemuPluginList *head)
+{
+    return 0;
+}
+
 static inline void qemu_plugin_vcpu_init_hook(CPUState *cpu)
 { }
 
-- 
2.20.1



  parent reply	other threads:[~2020-05-13 17:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 17:31 [PATCH v1 0/8] plugins/next (cleanup, cpu_index and lockstep) Alex Bennée
2020-05-13 17:31 ` [PATCH v1 1/8] qemu/plugin: Trivial code movement Alex Bennée
2020-05-13 17:31 ` Alex Bennée [this message]
2020-05-13 17:31 ` [PATCH v1 3/8] qemu/qemu-plugin: Make qemu_plugin_hwaddr_is_io() hwaddr argument const Alex Bennée
2020-05-13 17:31 ` [PATCH v1 4/8] MAINTAINERS: update the orphaned cpus-common.c file Alex Bennée
2020-05-13 19:26   ` Philippe Mathieu-Daudé
2020-05-13 17:31 ` [PATCH v1 5/8] cpus-common: ensure auto-assigned cpu_indexes don't clash Alex Bennée
2020-05-14 16:27   ` Alex Bennée
2020-05-21 15:53     ` Igor Mammedov
2020-05-21 17:10       ` Alex Bennée
2020-05-22  8:46         ` Igor Mammedow
2020-05-13 17:31 ` [PATCH v1 6/8] linux-user: properly "unrealize" vCPU object Alex Bennée
2020-05-22  9:35   ` Philippe Mathieu-Daudé
2020-05-13 17:31 ` [PATCH v1 7/8] tests/tcg: add new threadcount test Alex Bennée
2020-05-15 19:51   ` Nikolay Igotti
2020-05-22  9:33   ` Philippe Mathieu-Daudé
2020-05-13 17:32 ` [PATCH v1 8/8] plugins: new lockstep plugin for debugging TCG changes Alex Bennée
2020-05-13 19:25 ` [PATCH v1 0/8] plugins/next (cleanup, cpu_index and lockstep) Philippe Mathieu-Daudé
2020-05-14  0:56 ` no-reply
2020-05-14  1:36 ` no-reply
2020-05-14  1:36 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513173200.11830-3-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).