From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C895C433DF for ; Tue, 19 May 2020 09:41:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED5CE207D3 for ; Tue, 19 May 2020 09:41:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED5CE207D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaykP-00016D-4H for qemu-devel@archiver.kernel.org; Tue, 19 May 2020 05:41:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jayjn-0000S6-UU for qemu-devel@nongnu.org; Tue, 19 May 2020 05:40:39 -0400 Received: from 3.mo179.mail-out.ovh.net ([178.33.251.175]:45849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jayjl-0008Vk-Nk for qemu-devel@nongnu.org; Tue, 19 May 2020 05:40:39 -0400 Received: from player759.ha.ovh.net (unknown [10.110.115.229]) by mo179.mail-out.ovh.net (Postfix) with ESMTP id 5EDBC168757 for ; Tue, 19 May 2020 11:40:34 +0200 (CEST) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player759.ha.ovh.net (Postfix) with ESMTPSA id 742111287CC77; Tue, 19 May 2020 09:40:29 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-95G00117481720-402c-4b58-89d9-b7b1e3b4b640,70C5C5024F1CAF4ABF6ABE2DC9B39611306C745C) smtp.auth=groug@kaod.org Date: Tue, 19 May 2020 11:40:28 +0200 From: Greg Kurz To: =?UTF-8?B?Q8OpZHJpYw==?= Le Goater Subject: Re: [PATCH 0/9] ppc/pnv: Introduce the XIVE2 and PHB5 controllers for the POWER10 chip Message-ID: <20200519114028.69b11907@bahia.lan> In-Reply-To: <20200513151109.453530-1-clg@kaod.org> References: <20200513151109.453530-1-clg@kaod.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 12218828740457437579 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduhedruddtjedgudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfesthhqredtredtjeenucfhrhhomhepifhrvghgucfmuhhriicuoehgrhhouhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepueekjeekiefffedtveeukedvteejgeeivefhgfejgfdtleduvdfgfeelkeeuveeunecukfhppedtrddtrddtrddtpdekvddrvdehfedrvddtkedrvdegkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejheelrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepghhrohhugheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhuqdguvghvvghlsehnohhnghhnuhdrohhrgh Received-SPF: pass client-ip=178.33.251.175; envelope-from=groug@kaod.org; helo=3.mo179.mail-out.ovh.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/19 05:40:34 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 13 May 2020 17:11:00 +0200 C=C3=A9dric Le Goater wrote: > Hello, >=20 > This series completes the PowerNV POWER10 machine with the XIVE2 > interrupt controller and the PHB5 PCI host bridge controller. >=20 > The XIVE2 interrupt controller of the POWER10 processor follows the > same logic than on POWER9 but the HW interface has been largely > reviewed. To avoid adding too much complexity in the P9 XIVE models, > a new XIVE2 core framework is introduced. >=20 > The PHB5 and PHB4 controllers are very similar. Not much changes there > apart from the mapping addresses and ids. There is more to come on > PHB5 regarding interrupt offload on the interrupt controller, but this > is for another round. >=20 > This series also adds basic OCC and CPU Quad models which are not very > much exercised by the firmware. >=20 > Thanks, >=20 > C. >=20 This series is huge and it requires great knowledge of the HW, that I don't have (who does? ;-), to do a real review. I'll stick to find obvious errors and nits... > C=C3=A9dric Le Goater (9): > ppc/xive: Export PQ get/set routines > ppc/xive: Export xive_presenter_notify() > ppc/xive2: Introduce a XIVE2 core framework > ppc/xive2: Introduce a presenter matching routine > ppc/pnv: Add a XIVE2 controller to the POWER10 chip. > ppc/pnv: Add a OCC model for POWER10 > ppc/pnv: Add POWER10 quads > ppc/pnv: Add model for POWER9 PHB5 PCIe Host bridge > ppc/psi: Add support for StoreEOI and 64k ESB pages (POWER10) >=20 > hw/intc/pnv_xive2_regs.h | 428 +++++++ > include/hw/pci-host/pnv_phb4.h | 11 + > include/hw/ppc/pnv.h | 30 + > include/hw/ppc/pnv_occ.h | 2 + > include/hw/ppc/pnv_xive.h | 71 ++ > include/hw/ppc/pnv_xscom.h | 12 + > include/hw/ppc/xive.h | 8 + > include/hw/ppc/xive2.h | 93 ++ > include/hw/ppc/xive2_regs.h | 198 ++++ > hw/intc/pnv_xive2.c | 2026 ++++++++++++++++++++++++++++++++ > hw/intc/spapr_xive_kvm.c | 8 +- > hw/intc/xive.c | 14 +- > hw/intc/xive2.c | 756 ++++++++++++ > hw/pci-host/pnv_phb4_pec.c | 44 + > hw/ppc/pnv.c | 243 +++- > hw/ppc/pnv_occ.c | 17 + > hw/ppc/pnv_psi.c | 32 +- > hw/intc/Makefile.objs | 4 +- > 18 files changed, 3974 insertions(+), 23 deletions(-) > create mode 100644 hw/intc/pnv_xive2_regs.h > create mode 100644 include/hw/ppc/xive2.h > create mode 100644 include/hw/ppc/xive2_regs.h > create mode 100644 hw/intc/pnv_xive2.c > create mode 100644 hw/intc/xive2.c >=20