From: Eduardo Habkost <ehabkost@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: imammedo@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH 2/2] qmp: Expose MachineClass::default_ram_id
Date: Mon, 25 May 2020 14:06:03 -0400 [thread overview]
Message-ID: <20200525180603.GS577771@habkost.net> (raw)
In-Reply-To: <2dbffbc4e2c0f3a0184daaadf56f94a85aedef58.1590426097.git.mprivozn@redhat.com>
On Mon, May 25, 2020 at 07:03:28PM +0200, Michal Privoznik wrote:
> If a management application (like Libvirt) want's to preserve
> migration ability and switch to '-machine memory-backend' it
> needs to set exactly the same RAM id as QEMU would. Since the id
> is machine type dependant, expose it under 'query-machines'
> result.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
The code looks good, but documentation was a bit confusing:
> ---
[...]
> +# @default-ram-id: the default name of initial RAM memory region (since 5.1)
> +#
Everywhere else in the commit message you call it "id", but here
you say "name". Also, I don't think we have any references to a
"memory region" abstraction in the docs for the QAPI schema,
-machine options, or memory backend objects.
I had to look it up in the code, to finally understand you were
talking about the memory backend object ID.
To make it consistent with terminology used for -machine and
QAPI, I suggest:
@default-ram-id: the default ID of initial RAM memory backend (since 5.1)
I can change it before committing, if you agree.
> # @default-cpu-type: default CPU model typename if none is requested via
> # the -cpu argument. (since 4.2)
> #
> @@ -361,7 +363,8 @@
> 'data': { 'name': 'str', '*alias': 'str',
> '*is-default': 'bool', 'cpu-max': 'int',
> 'hotpluggable-cpus': 'bool', 'numa-mem-supported': 'bool',
> - 'deprecated': 'bool', '*default-cpu-type': 'str' } }
> + 'deprecated': 'bool', 'default-ram-id': 'str',
> + '*default-cpu-type': 'str' } }
>
> ##
> # @query-machines:
> --
> 2.26.2
>
--
Eduardo
next prev parent reply other threads:[~2020-05-25 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 17:03 [PATCH 0/2] qmp: Expose MachineClass::default_ram_id Michal Privoznik
2020-05-25 17:03 ` [PATCH 1/2] qapi: Fix comment format for @CpuInstanceProperties Michal Privoznik
2020-05-26 20:02 ` Eric Blake
2020-05-25 17:03 ` [PATCH 2/2] qmp: Expose MachineClass::default_ram_id Michal Privoznik
2020-05-25 18:06 ` Eduardo Habkost [this message]
2020-05-26 8:06 ` Michal Privoznik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525180603.GS577771@habkost.net \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).