From: Gerd Hoffmann <kraxel@redhat.com>
To: Bruce Rogers <brogers@suse.com>
Cc: qemu-devel@nongnu.org, dirty.ice.hu@gmail.com
Subject: Re: [PATCH] audio: fix wavcapture segfault
Date: Tue, 26 May 2020 07:56:11 +0200 [thread overview]
Message-ID: <20200526055611.bqazfxqjxusrmwca@sirius.home.kraxel.org> (raw)
In-Reply-To: <20200521172931.121903-1-brogers@suse.com>
On Thu, May 21, 2020 at 11:29:31AM -0600, Bruce Rogers wrote:
> Commit 571a8c522e caused the HMP wavcapture command to segfault when
> processing audio data in audio_pcm_sw_write(), where a NULL
> sw->hw->pcm_ops is dereferenced. This fix checks that the pointer is
> valid before dereferincing it. A similar fix is also made in the
> parallel function audio_pcm_sw_read().
>
> Fixes: 571a8c522e (audio: split ctl_* functions into enable_* and
> volume_*)
> Signed-off-by: Bruce Rogers <brogers@suse.com>
Added to audio queue.
thanks,
Gerd
prev parent reply other threads:[~2020-05-26 5:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 17:29 [PATCH] audio: fix wavcapture segfault Bruce Rogers
2020-05-21 20:09 ` Philippe Mathieu-Daudé
2020-05-26 5:56 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526055611.bqazfxqjxusrmwca@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=brogers@suse.com \
--cc=dirty.ice.hu@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).