From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF7EDC433E0 for ; Tue, 26 May 2020 11:39:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87E762084C for ; Tue, 26 May 2020 11:39:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ge2LAGn6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87E762084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdXvk-0004fA-Ni for qemu-devel@archiver.kernel.org; Tue, 26 May 2020 07:39:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdXv4-0004Dy-Fw for qemu-devel@nongnu.org; Tue, 26 May 2020 07:38:54 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:55431 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jdXv2-0002xW-2P for qemu-devel@nongnu.org; Tue, 26 May 2020 07:38:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590493130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JcbJZi70/70dwSaLCJBJandA6KinpXRZakO0iir+6ok=; b=ge2LAGn6Q9hWcolSAZ71oHysVsWFRTC+zri6SYY/UtKsJaZxSQ4VZgaiFJg6X3Vqy3BXYJ MhGy9L1ksiO8bJ+X+r60KezdcbYsBnSE1Gqvf/no0SHDe55wH94LWDz4xSiRe+CrSVHxuy 9WcKcksijNRM0o+mjPMuYlwyPfrzVnA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-SgoJMYOhM66Ior47wTb4yg-1; Tue, 26 May 2020 07:38:47 -0400 X-MC-Unique: SgoJMYOhM66Ior47wTb4yg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF7971005510; Tue, 26 May 2020 11:38:45 +0000 (UTC) Received: from gondolin (ovpn-113-77.ams2.redhat.com [10.36.113.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C0836EF80; Tue, 26 May 2020 11:38:40 +0000 (UTC) Date: Tue, 26 May 2020 13:38:36 +0200 From: Cornelia Huck To: Paolo Bonzini Subject: Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices Message-ID: <20200526133836.7dd0c7dc.cohuck@redhat.com> In-Reply-To: <38aea6e3-a076-f29f-0167-f6ba084f5bb8@redhat.com> References: <20200519145551.22836-1-armbru@redhat.com> <20200519145551.22836-51-armbru@redhat.com> <20200526114523.65082262.cohuck@redhat.com> <38aea6e3-a076-f29f-0167-f6ba084f5bb8@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/26 01:14:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, ehabkost@redhat.com, David Hildenbrand , Markus Armbruster , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 26 May 2020 13:23:43 +0200 Paolo Bonzini wrote: > On 26/05/20 11:45, Cornelia Huck wrote: > > On Tue, 19 May 2020 16:55:46 +0200 > > Markus Armbruster wrote: > > > >> init_event_facility() creates the SCLP events bus with two SCLP event > >> devices (sclpquiesce and sclp-cpu-hotplug). It leaves the devices > >> unrealized. A comment explains they will be realized "via the bus". > >> > >> The bus's realize method sclp_events_bus_realize() indeed realizes all > >> unrealized devices on this bus. It carries a TODO comment claiming > >> this "has to be done in common code". No other bus realize method > >> realizes its devices. > >> > >> The common code in question is bus_set_realized(), which has a TODO > >> comment asking for recursive realization. It's been asking for years. > >> > >> The only devices sclp_events_bus_realize() will ever realize are the > >> two init_event_facility() puts there. > >> > >> Simplify as follows: > >> > >> * Make the devices members of the event facility instance struct, just > >> like the bus. object_initialize_child() is simpler than > >> object_property_add_child() and object_unref(). > >> > >> * Realize them in the event facility realize method. > >> > >> This is in line with how such things are done elsewhere. > >> > >> Cc: Cornelia Huck > >> Cc: Halil Pasic > >> Cc: Christian Borntraeger > >> Cc: Richard Henderson > >> Cc: David Hildenbrand > >> Cc: qemu-s390x@nongnu.org > >> Signed-off-by: Markus Armbruster > >> --- > >> hw/s390x/event-facility.c | 59 ++++++++++++++++----------------------- > >> 1 file changed, 24 insertions(+), 35 deletions(-) > > > > So, what should happen with this patch? Should it go with the rest of > > the series, or should it go through the s390 tree? > > I think an Acked-by is the simplest way to handle it, since qdev_realize > doesn't exist upstream. Ok, let's keep them together. Acked-by: Cornelia Huck