From: Igor Mammedov <imammedo@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com
Subject: Re: [PATCH v2 2/2] qmp: Expose MachineClass::default_ram_id
Date: Tue, 26 May 2020 15:15:51 +0200 [thread overview]
Message-ID: <20200526151551.70ba3c10@redhat.com> (raw)
In-Reply-To: <9384422f63fe594a54d801f9cb4539b1d2ce9b67.1590481402.git.mprivozn@redhat.com>
On Tue, 26 May 2020 10:25:35 +0200
Michal Privoznik <mprivozn@redhat.com> wrote:
> If a management application (like Libvirt) want's to preserve
> migration ability and switch to '-machine memory-backend' it
> needs to set exactly the same RAM id as QEMU would. Since the id
> is machine type dependant, expose it under 'query-machines'
> result. Some machine types don't have the attribute set (riscv
> family for example), therefore the QMP attribute must be
> optional.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
> hw/core/machine-qmp-cmds.c | 4 ++++
> qapi/machine.json | 5 ++++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
> index 2c5da8413d..3e11a740c9 100644
> --- a/hw/core/machine-qmp-cmds.c
> +++ b/hw/core/machine-qmp-cmds.c
> @@ -238,6 +238,10 @@ MachineInfoList *qmp_query_machines(Error **errp)
> info->default_cpu_type = g_strdup(mc->default_cpu_type);
> info->has_default_cpu_type = true;
> }
> + if (mc->default_ram_id) {
> + info->default_ram_id = g_strdup(mc->default_ram_id);
> + info->has_default_ram_id = true;
> + }
>
> entry = g_malloc0(sizeof(*entry));
> entry->value = info;
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 39caa1d914..76c1606390 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -355,13 +355,16 @@
> # @default-cpu-type: default CPU model typename if none is requested via
> # the -cpu argument. (since 4.2)
> #
> +# @default-ram-id: the default ID of initial RAM memory backend (since 5.1)
> +#
> # Since: 1.2.0
> ##
> { 'struct': 'MachineInfo',
> 'data': { 'name': 'str', '*alias': 'str',
> '*is-default': 'bool', 'cpu-max': 'int',
> 'hotpluggable-cpus': 'bool', 'numa-mem-supported': 'bool',
> - 'deprecated': 'bool', '*default-cpu-type': 'str' } }
> + 'deprecated': 'bool', '*default-cpu-type': 'str',
> + '*default-ram-id': 'str' } }
>
> ##
> # @query-machines:
next prev parent reply other threads:[~2020-05-26 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 8:25 [PATCH v2 0/2] qmp: Expose MachineClass::default_ram_id Michal Privoznik
2020-05-26 8:25 ` [PATCH v2 1/2] qapi: Fix comment format for @CpuInstanceProperties Michal Privoznik
2020-05-26 13:11 ` Igor Mammedov
2020-05-26 8:25 ` [PATCH v2 2/2] qmp: Expose MachineClass::default_ram_id Michal Privoznik
2020-05-26 13:15 ` Igor Mammedov [this message]
2020-05-26 13:17 ` Igor Mammedov
2020-07-27 18:41 ` [PATCH v2 0/2] " Eduardo Habkost
2020-07-28 8:05 ` Michal Privoznik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526151551.70ba3c10@redhat.com \
--to=imammedo@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).