From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "David Hildenbrand" <david@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
qemu-s390x@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Roman Bolshakov" <r.bolshakov@yadro.com>,
qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v2 5/7] target/s390x: Only compile decode_basedisp() on system-mode
Date: Tue, 26 May 2020 19:24:25 +0200 [thread overview]
Message-ID: <20200526172427.17460-6-f4bug@amsat.org> (raw)
In-Reply-To: <20200526172427.17460-1-f4bug@amsat.org>
The decode_basedisp*() methods are only used in ioinst.c,
which is only build in system-mode emulation.
I/O instructions are privileged, and other S instructions
are decoded elsewhere.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/s390x/internal.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/s390x/internal.h b/target/s390x/internal.h
index 8c95c734db..c1678dc6bc 100644
--- a/target/s390x/internal.h
+++ b/target/s390x/internal.h
@@ -204,6 +204,8 @@ enum cc_op {
CC_OP_MAX
};
+#ifndef CONFIG_USER_ONLY
+
static inline hwaddr decode_basedisp_s(CPUS390XState *env, uint32_t ipb,
uint8_t *ar)
{
@@ -225,6 +227,8 @@ static inline hwaddr decode_basedisp_s(CPUS390XState *env, uint32_t ipb,
/* Base/displacement are at the same locations. */
#define decode_basedisp_rs decode_basedisp_s
+#endif /* CONFIG_USER_ONLY */
+
/* arch_dump.c */
int s390_cpu_write_elf64_note(WriteCoreDumpFunction f, CPUState *cs,
int cpuid, void *opaque);
--
2.21.3
next prev parent reply other threads:[~2020-05-26 17:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:24 [PATCH v2 0/7] exec/cpu: Cleanups around "exec/hwaddr.h" (reserved to system-mode) Philippe Mathieu-Daudé
2020-05-26 17:24 ` [PATCH v2 1/7] sysemu/accel: Restrict machine methods to system-mode Philippe Mathieu-Daudé
2020-05-26 19:49 ` Roman Bolshakov
2020-05-26 17:24 ` [PATCH v2 2/7] sysemu/tcg: Only declare tcg_allowed when TCG is available Philippe Mathieu-Daudé
2020-05-26 17:24 ` [PATCH v2 3/7] sysemu/hvf: Only declare hvf_allowed when HVF " Philippe Mathieu-Daudé
2020-05-26 19:18 ` Roman Bolshakov
2020-05-26 17:24 ` [PATCH v2 4/7] target/ppc: Restrict PPCVirtualHypervisorClass to system-mode Philippe Mathieu-Daudé
2020-05-26 17:24 ` Philippe Mathieu-Daudé [this message]
2020-05-26 17:24 ` [PATCH v2 6/7] target/s390x/helper: Clean ifdef'ry Philippe Mathieu-Daudé
2020-05-26 17:24 ` [PATCH v2 7/7] target/s390x: Restrict system-mode declarations Philippe Mathieu-Daudé
2020-05-27 6:10 ` Cornelia Huck
2020-05-27 6:13 ` [PATCH v2 0/7] exec/cpu: Cleanups around "exec/hwaddr.h" (reserved to system-mode) Cornelia Huck
2020-06-04 12:29 ` Cornelia Huck
2020-06-04 18:11 ` Paolo Bonzini
2020-06-05 14:18 ` Cornelia Huck
2020-06-05 15:00 ` Paolo Bonzini
2020-06-05 15:13 ` Cornelia Huck
2020-06-05 15:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526172427.17460-6-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).