From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41BAFC433DF for ; Tue, 26 May 2020 17:32:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05F442053B for ; Tue, 26 May 2020 17:32:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C0EbywkV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05F442053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jddRP-0002m7-5I for qemu-devel@archiver.kernel.org; Tue, 26 May 2020 13:32:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jddPK-0001DH-UO for qemu-devel@nongnu.org; Tue, 26 May 2020 13:30:30 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:32278 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jddPJ-0008Mt-3A for qemu-devel@nongnu.org; Tue, 26 May 2020 13:30:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590514228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UBqdWjmEc/msbKZwVVNYZNJeNnDanGxhIaX85cc6jhY=; b=C0EbywkV+nFsvX9gksSEHEc5Fdf430+9XeiOdU5hYgPtiCOCTjfD8r7+iBD/RrWaDn38kt 8tnVBYVH7cvZPWaF00UkRTMyT0p0HoVncfGJOwtD9Shmy+WNMPdcej7YXI++UDms+tMg3l yTKPwv9qUh05XCxJ2uZzcNnJaEN5hhM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-55-0mNBKSTLPGG9IZO9UvjDXA-1; Tue, 26 May 2020 13:30:25 -0400 X-MC-Unique: 0mNBKSTLPGG9IZO9UvjDXA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6ECF107ACF4; Tue, 26 May 2020 17:30:23 +0000 (UTC) Received: from work-vm (ovpn-112-104.ams2.redhat.com [10.36.112.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74AB97A1E2; Tue, 26 May 2020 17:30:00 +0000 (UTC) Date: Tue, 26 May 2020 18:29:57 +0100 From: "Dr. David Alan Gilbert" To: Stefan Hajnoczi Subject: Re: [PATCH 5/5] virtio: enable VIRTIO_F_RING_PACKED for all devices Message-ID: <20200526172957.GL2864@work-vm> References: <20200522171726.648279-1-stefanha@redhat.com> <20200522171726.648279-6-stefanha@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200522171726.648279-6-stefanha@redhat.com> User-Agent: Mutt/1.13.4 (2020-02-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=dgilbert@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/26 01:51:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, T_HK_NAME_DR=0.01 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Laurent Vivier , Thomas Huth , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , jasowang@redhat.com, cohuck@redhat.com, qemu-devel@nongnu.org, Raphael Norwitz , "Gonglei \(Arei\)" , Gerd Hoffmann , Paolo Bonzini , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Fam Zheng , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Stefan Hajnoczi (stefanha@redhat.com) wrote: > The packed virtqueue layout was introduced in VIRTIO 1.1. It is a single > ring instead of a split avail/used ring design. There are CPU cache > advantages to this layout and it is also suited better to hardware > implementation. > > The vhost-net backend has already supported packed virtqueues for some > time. Performance benchmarks show that virtio-blk performance on NVMe > drives is also improved. > > Go ahead and enable this feature for all VIRTIO devices. Keep it > disabled for QEMU 5.0 and earlier machine types. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Dr. David Alan Gilbert > --- > include/hw/virtio/virtio.h | 2 +- > hw/core/machine.c | 18 +++++++++++++++++- > 2 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > index b69d517496..fd5b4a2044 100644 > --- a/include/hw/virtio/virtio.h > +++ b/include/hw/virtio/virtio.h > @@ -292,7 +292,7 @@ typedef struct VirtIORNGConf VirtIORNGConf; > DEFINE_PROP_BIT64("iommu_platform", _state, _field, \ > VIRTIO_F_IOMMU_PLATFORM, false), \ > DEFINE_PROP_BIT64("packed", _state, _field, \ > - VIRTIO_F_RING_PACKED, false) > + VIRTIO_F_RING_PACKED, true) > > hwaddr virtio_queue_get_desc_addr(VirtIODevice *vdev, int n); > bool virtio_queue_enabled(VirtIODevice *vdev, int n); > diff --git a/hw/core/machine.c b/hw/core/machine.c > index bb3a7b18b1..3598c3c825 100644 > --- a/hw/core/machine.c > +++ b/hw/core/machine.c > @@ -28,7 +28,23 @@ > #include "hw/mem/nvdimm.h" > #include "migration/vmstate.h" > > -GlobalProperty hw_compat_5_0[] = {}; > +GlobalProperty hw_compat_5_0[] = { > + { "vhost-user-blk", "packed", "off" }, > + { "vhost-user-fs-device", "packed", "off" }, > + { "vhost-vsock-device", "packed", "off" }, > + { "virtio-9p-device", "packed", "off" }, > + { "virtio-balloon-device", "packed", "off" }, > + { "virtio-blk-device", "packed", "off" }, > + { "virtio-crypto-device", "packed", "off" }, > + { "virtio-gpu-device", "packed", "off" }, > + { "virtio-input-device", "packed", "off" }, > + { "virtio-iommu-device", "packed", "off" }, > + { "virtio-net-device", "packed", "off" }, > + { "virtio-pmem", "packed", "off" }, > + { "virtio-rng-device", "packed", "off" }, > + { "virtio-scsi-common", "packed", "off" }, > + { "virtio-serial-device", "packed", "off" }, > +}; > const size_t hw_compat_5_0_len = G_N_ELEMENTS(hw_compat_5_0); > > GlobalProperty hw_compat_4_2[] = { > -- > 2.25.3 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK