From: Thomas Huth <huth@tuxfamily.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-trivial@nongnu.org, Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 1/2] hw/m68k/mcf5206: Reduce m5206_mbar_read/write() offset arg to 16-bit
Date: Tue, 26 May 2020 17:59:14 +0200 [thread overview]
Message-ID: <20200526175914.7e3ed350@thl530> (raw)
In-Reply-To: <20200526094052.1723-2-f4bug@amsat.org>
Am Tue, 26 May 2020 11:40:51 +0200
schrieb Philippe Mathieu-Daudé <f4bug@amsat.org>:
> All calls to m5206_mbar_read/m5206_mbar_write are used with
> 'offset = hwaddr & 0x3ff', so we are sure the offset fits
> in 16-bit.
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v3: Use PRIx16
> ---
> hw/m68k/mcf5206.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/m68k/mcf5206.c b/hw/m68k/mcf5206.c
> index b155dd8170..187291e1f6 100644
> --- a/hw/m68k/mcf5206.c
> +++ b/hw/m68k/mcf5206.c
> @@ -273,7 +273,7 @@ static void m5206_mbar_reset(m5206_mbar_state *s)
> }
>
> static uint64_t m5206_mbar_read(m5206_mbar_state *s,
> - uint64_t offset, unsigned size)
> + uint16_t offset, unsigned size)
> {
> if (offset >= 0x100 && offset < 0x120) {
> return m5206_timer_read(s->timer[0], offset - 0x100);
> @@ -306,11 +306,11 @@ static uint64_t
> m5206_mbar_read(m5206_mbar_state *s, case 0x170: return s->uivr[0];
> case 0x1b0: return s->uivr[1];
> }
> - hw_error("Bad MBAR read offset 0x%x", (int)offset);
> + hw_error("Bad MBAR read offset 0x%"PRIx16, offset);
> return 0;
> }
>
> -static void m5206_mbar_write(m5206_mbar_state *s, uint32_t offset,
> +static void m5206_mbar_write(m5206_mbar_state *s, uint16_t offset,
> uint64_t value, unsigned size)
> {
> if (offset >= 0x100 && offset < 0x120) {
> @@ -360,7 +360,7 @@ static void m5206_mbar_write(m5206_mbar_state *s,
> uint32_t offset, s->uivr[1] = value;
> break;
> default:
> - hw_error("Bad MBAR write offset 0x%x", (int)offset);
> + hw_error("Bad MBAR write offset 0x%"PRIx16, offset);
> break;
> }
> }
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
next prev parent reply other threads:[~2020-05-26 16:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 9:40 [PATCH v3 0/2] hw/m68k/mcf52xx: Replace hw_error() by qemu_log_mask() Philippe Mathieu-Daudé
2020-05-26 9:40 ` [PATCH v3 1/2] hw/m68k/mcf5206: Reduce m5206_mbar_read/write() offset arg to 16-bit Philippe Mathieu-Daudé
2020-05-26 15:59 ` Thomas Huth [this message]
2020-05-26 9:40 ` [PATCH v3 2/2] hw/m68k/mcf52xx: Replace hw_error() by qemu_log_mask() Philippe Mathieu-Daudé
2020-05-26 16:04 ` Thomas Huth
2020-05-26 16:34 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526175914.7e3ed350@thl530 \
--to=huth@tuxfamily.org \
--cc=f4bug@amsat.org \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).