From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B4AAC433E1 for ; Wed, 27 May 2020 09:47:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2ED562088E for ; Wed, 27 May 2020 09:47:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZdnZ3sN8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2ED562088E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdseJ-0006q2-EU for qemu-devel@archiver.kernel.org; Wed, 27 May 2020 05:46:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdsdi-0006Q1-1m for qemu-devel@nongnu.org; Wed, 27 May 2020 05:46:22 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:30904 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jdsdg-0002uk-Ul for qemu-devel@nongnu.org; Wed, 27 May 2020 05:46:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590572779; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JGWU5b1GocXNyTNMO2lRvIwtMz+KbkqvYivgwe6Yr7o=; b=ZdnZ3sN8M7Ef3Pv509WeIG0fcXCXQ7F2b0Jm6WQrhMc94ibR/F4o/NHSll8ybGFkRuzSJt HNnyVCFsmsRh5FFCouRtLfzImJhKZ2kh4qk67nf4Ma/WnobmB34l7kRH0tMCIvlywI4TCp fmtLatkXpeekqsUoprOWnxSCoRNqt9I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-452-hMpAc6ONNWuVusGpURWz0w-1; Wed, 27 May 2020 05:46:17 -0400 X-MC-Unique: hMpAc6ONNWuVusGpURWz0w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3DC818FE873; Wed, 27 May 2020 09:46:16 +0000 (UTC) Received: from redhat.com (unknown [10.36.110.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 743635D9E5; Wed, 27 May 2020 09:46:15 +0000 (UTC) Date: Wed, 27 May 2020 10:46:12 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Alexey Krasikov Subject: Re: [PATCH v4 2/3] crypto/linux_keyring: add 'secret_keyring' secret object. Message-ID: <20200527094612.GF2665520@redhat.com> References: <20200525111913.4274-1-alex-krasikov@yandex-team.ru> MIME-Version: 1.0 In-Reply-To: <20200525111913.4274-1-alex-krasikov@yandex-team.ru> User-Agent: Mutt/1.13.4 (2020-02-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.61; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/27 05:46:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_EXCESS_BASE64=0.979, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: qemu-devel@nongnu.org, yc-core@yandex-team.ru Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, May 25, 2020 at 02:19:12PM +0300, Alexey Krasikov wrote: > Add the ability for the secret object to obtain secret data from the > Linux in-kernel key managment and retention facility, as an extra option > to the existing ones: reading from a file or passing directly as a > string. > > The secret is identified by the key serial number. The upper layers > need to instantiate the key and make sure the QEMU process has access > permissions to read it. > > Signed-off-by: Alexey Krasikov > Reviewed-by: Daniel P. Berrangé > --- > configure | 38 ++++++++ > crypto/Makefile.objs | 1 + > crypto/secret_keyring.c | 148 ++++++++++++++++++++++++++++++++ > include/crypto/secret_keyring.h | 52 +++++++++++ > 4 files changed, 239 insertions(+) > create mode 100644 crypto/secret_keyring.c > create mode 100644 include/crypto/secret_keyring.h > diff --git a/crypto/secret_keyring.c b/crypto/secret_keyring.c > new file mode 100644 > index 0000000000..aa29004639 > --- /dev/null > +++ b/crypto/secret_keyring.c > +static void > +qcrypto_secret_keyring_class_init(ObjectClass *oc, void *data) > +{ > + QCryptoSecretCommonClass *sic = QCRYPTO_SECRET_COMMON_CLASS(oc); > + sic->load_data = qcrypto_secret_keyring_load_data; > + > + UserCreatableClass *ucc = USER_CREATABLE_CLASS(oc); > + ucc->complete = qcrypto_secret_keyring_complete; > + > + object_class_property_add(oc, "serial", "int32_t", > + qcrypto_secret_prop_get_key, > + qcrypto_secret_prop_set_key, > + NULL, NULL, NULL); This doesn't compile because of the extra arg, so not sure how you tested this. Since this is the only mistake, I'll fix it myself when quueing these patches. Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|