From: Kevin Wolf <kwolf@redhat.com>
To: Sergio Lopez <slp@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH 0/2] virtio-blk: Avoid processing requests on the main context on restart
Date: Wed, 3 Jun 2020 16:14:25 +0200 [thread overview]
Message-ID: <20200603141425.GE5127@linux.fritz.box> (raw)
In-Reply-To: <20200603093240.40489-1-slp@redhat.com>
Am 03.06.2020 um 11:32 hat Sergio Lopez geschrieben:
> On restart, we were scheduling a BH to process queued requests, which
> would run before starting up the data plane, leading to those requests
> being assigned and started on coroutines on the main context.
>
> This could cause requests to be wrongly processed in parallel from
> different threads (the main thread and the iothread managing the data
> plane), potentially leading to multiple issues.
>
> Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1812765
>
> See "virtio-blk: Disable request queuing while switching contexts" for
> previous discussion:
>
> - https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg00304.html
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2020-06-03 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 9:32 [PATCH 0/2] virtio-blk: Avoid processing requests on the main context on restart Sergio Lopez
2020-06-03 9:32 ` [PATCH 1/2] virtio-blk: Refactor the code that processes queued requests Sergio Lopez
2020-06-03 9:32 ` [PATCH 2/2] virtio-blk: On restart, process queued requests in the proper context Sergio Lopez
2020-06-03 14:14 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603141425.GE5127@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).