From: Peter Xu <peterx@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Julia Suvorova" <jusual@redhat.com>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] pci: Display PCI IRQ pin in "info pci"
Date: Tue, 9 Jun 2020 12:13:28 -0400 [thread overview]
Message-ID: <20200609161328.GB3061@xz-x1> (raw)
In-Reply-To: <20200609114913-mutt-send-email-mst@kernel.org>
On Tue, Jun 09, 2020 at 11:49:49AM -0400, Michael S. Tsirkin wrote:
> > > > > @@ -417,8 +419,8 @@
> > > > > { 'struct': 'PciDeviceInfo',
> > > > > 'data': {'bus': 'int', 'slot': 'int', 'function': 'int',
> > > > > 'class_info': 'PciDeviceClass', 'id': 'PciDeviceId',
> > > > > - '*irq': 'int', 'qdev_id': 'str', '*pci_bridge': 'PciBridgeInfo',
> > > > > - 'regions': ['PciMemoryRegion']} }
> > > > > + '*irq': 'int', 'irq_pin': 'int', 'qdev_id': 'str',
> > > > > + '*pci_bridge': 'PciBridgeInfo', 'regions': ['PciMemoryRegion'] }}
> > > >
> > > > and the pre-existing pci_bridge is indeed the consistency issue.
> > >
> > > Yeh, actually every key in this struct. :)
> >
> > Using 'irq-pin':
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
>
> Peter can you fix and repost pls?
I still think irq_pin is better because as I mentioned previously all the
existing keys are using underscores... Phil?
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2020-06-09 16:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 19:59 [PATCH] pci: Display PCI IRQ pin in "info pci" Peter Xu
2020-03-17 20:02 ` Eric Blake
2020-03-17 20:11 ` Peter Xu
2020-03-18 17:06 ` Philippe Mathieu-Daudé
2020-06-09 15:49 ` Michael S. Tsirkin
2020-06-09 16:13 ` Peter Xu [this message]
2020-06-09 16:18 ` Philippe Mathieu-Daudé
2020-06-09 17:53 ` Peter Xu
2020-06-09 18:09 ` Michael S. Tsirkin
2020-03-17 20:21 ` Dr. David Alan Gilbert
2020-03-17 20:36 ` Peter Xu
2020-03-18 9:23 ` Dr. David Alan Gilbert
2020-05-23 20:34 ` Peter Xu
2020-05-25 8:19 ` Markus Armbruster
2020-05-25 14:14 ` Peter Xu
2020-05-26 8:27 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609161328.GB3061@xz-x1 \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jusual@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).