From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E216C433E0 for ; Thu, 11 Jun 2020 18:53:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD8B8206DC for ; Thu, 11 Jun 2020 18:53:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F+0vR9oY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD8B8206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjSKV-000490-W8 for qemu-devel@archiver.kernel.org; Thu, 11 Jun 2020 14:53:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjSJD-0002bV-NI for qemu-devel@nongnu.org; Thu, 11 Jun 2020 14:52:16 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:50453 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jjSJA-0005To-43 for qemu-devel@nongnu.org; Thu, 11 Jun 2020 14:52:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591901530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hi/hupA3QJDP1QW6qWiYTsGLdM4MOK2OL5CiHvFRMYI=; b=F+0vR9oYusV2vUcXYAe/bvqS5lbOKTGIhisgZeH5eKGPB3rGid5ZBJemxdNX0IQJnMFgvU 05Pa3qjKGW/mpYDDvwceE0N2zNiefQ/gEK4C/twUMOee5KA5PBTNR/bRnKBJPbl2jGAeGX nbgGB0X/H39vppe5vC69VQbKfi4GJQg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-502-SLhAMKx2MM6wztqhC-aiTQ-1; Thu, 11 Jun 2020 14:52:08 -0400 X-MC-Unique: SLhAMKx2MM6wztqhC-aiTQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4DC40100CCC8; Thu, 11 Jun 2020 18:52:07 +0000 (UTC) Received: from work-vm (ovpn-114-116.ams2.redhat.com [10.36.114.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B4CED1A8EA; Thu, 11 Jun 2020 18:52:05 +0000 (UTC) Date: Thu, 11 Jun 2020 19:52:03 +0100 From: "Dr. David Alan Gilbert" To: Mao Zhongyi Subject: Re: [PATCH 5/9] monitor/hmp-cmds: delete redundant Error check before invoke hmp_handle_error() Message-ID: <20200611185203.GA2969@work-vm> References: <20200603080904.997083-1-maozhongyi@cmss.chinamobile.com> <20200603080904.997083-6-maozhongyi@cmss.chinamobile.com> MIME-Version: 1.0 In-Reply-To: <20200603080904.997083-6-maozhongyi@cmss.chinamobile.com> User-Agent: Mutt/1.14.0 (2020-05-02) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=dgilbert@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/11 14:52:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Mao Zhongyi (maozhongyi@cmss.chinamobile.com) wrote: > hmp_handle_error() does Error check internally. > > Signed-off-by: Mao Zhongyi Reviewed-by: Dr. David Alan Gilbert > --- > monitor/hmp-cmds.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index 6938f1060e..acdd6baff3 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -1636,9 +1636,8 @@ void hmp_object_add(Monitor *mon, const QDict *qdict) > obj = user_creatable_add_opts(opts, &err); > qemu_opts_del(opts); > > - if (err) { > - hmp_handle_error(mon, err); > - } > + hmp_handle_error(mon, err); > + > if (obj) { > object_unref(obj); > } > -- > 2.17.1 > > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK