From: Greg Kurz <groug@kaod.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Laurent Vivier <lvivier@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH v3 4/4] spapr: Forbid nested KVM-HV in pre-power9 compat mode
Date: Mon, 15 Jun 2020 11:20:31 +0200 [thread overview]
Message-ID: <20200615112031.679512c3@bahia.lan> (raw)
In-Reply-To: <20200613071804.GE5861@umbus.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 2525 bytes --]
On Sat, 13 Jun 2020 17:18:04 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Thu, Jun 11, 2020 at 03:40:33PM +0200, Greg Kurz wrote:
> > Nested KVM-HV only works on POWER9.
> >
> > Signed-off-by: Greg Kurz <groug@kaod.org>
> > Reviewed-by: Laurent Vivier <lvivier@redhat.com>
>
> Hrm. I have mixed feelings about this. It does bring forward an
> error that we'd otherwise only discover when we try to load the kvm
> module in the guest.
>
> On the other hand, it's kind of a layering violation - really it's
> KVM's business to report what it can and can't do, rather than having
> qemu anticipate it.
>
Agreed and it seems that we can probably get KVM to report that
already. I'll have closer look.
> Allowing POWER8 compat for an L2 is something we hope to have in the
> fairly near future.
Ok but I guess we don't want to start an L2 in compat POWER8 mode
with cap-nested-hv=on, do we ?
> Allowing POWER8 compat for L1, which is what this
> covers, is, I'll admit, likely to never happen.
>
>
> > ---
> > HW/ppc/spapr_caps.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c
> > index 27cf2b38af27..dfe3b419daaa 100644
> > --- a/hw/ppc/spapr_caps.c
> > +++ b/hw/ppc/spapr_caps.c
> > @@ -391,6 +391,8 @@ static void cap_nested_kvm_hv_apply(SpaprMachineState *spapr,
> > uint8_t val, Error **errp)
> > {
> > ERRP_AUTO_PROPAGATE();
> > + PowerPCCPU *cpu = POWERPC_CPU(first_cpu);
> > +
> > if (!val) {
> > /* capability disabled by default */
> > return;
> > @@ -400,6 +402,14 @@ static void cap_nested_kvm_hv_apply(SpaprMachineState *spapr,
> > error_setg(errp, "No Nested KVM-HV support in TCG");
> > error_append_hint(errp, "Try appending -machine cap-nested-hv=off\n");
> > } else if (kvm_enabled()) {
> > + if (!ppc_check_compat(cpu, CPU_POWERPC_LOGICAL_3_00, 0,
> > + spapr->max_compat_pvr)) {
> > + error_setg(errp, "Nested KVM-HV only supported on POWER9");
> > + error_append_hint(errp,
> > + "Try appending -machine max-cpu-compat=power9\n");
> > + return;
> > + }
> > +
> > if (!kvmppc_has_cap_nested_kvm_hv()) {
> > error_setg(errp,
> > "KVM implementation does not support Nested KVM-HV");
> >
> >
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-06-15 9:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 13:40 [PATCH v3 0/4] spapr: Improve error reporting in spapr_caps.c Greg Kurz
2020-06-11 13:40 ` [PATCH v3 1/4] spapr: Simplify some warning printing paths " Greg Kurz
2020-06-11 14:37 ` Vladimir Sementsov-Ogievskiy
2020-06-11 15:33 ` Laurent Vivier
2020-06-12 9:46 ` David Gibson
2020-06-11 13:40 ` [PATCH v3 2/4] error: auto propagated local_err Greg Kurz
2020-06-13 7:12 ` David Gibson
2020-06-15 6:42 ` Greg Kurz
2020-06-11 13:40 ` [PATCH v3 3/4] spapr: Use error_append_hint() in spapr_caps.c Greg Kurz
2020-06-11 15:35 ` Laurent Vivier
2020-06-11 13:40 ` [PATCH v3 4/4] spapr: Forbid nested KVM-HV in pre-power9 compat mode Greg Kurz
2020-06-13 7:18 ` David Gibson
2020-06-15 9:20 ` Greg Kurz [this message]
2020-06-18 23:59 ` David Gibson
2020-07-03 14:19 ` Greg Kurz
2020-07-13 4:53 ` David Gibson
2020-07-15 11:14 ` Greg Kurz
2020-07-15 23:26 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615112031.679512c3@bahia.lan \
--to=groug@kaod.org \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).