On Wed, 17 Jun 2020 16:12:40 +0100 Stefan Hajnoczi wrote: > On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote: > > +static struct YankInstance *yank_find_instance(char *name) > > There are const char * -> char * casts in later patches. Please use > const char * where possible. Callers shouldn't need to cast away const. nbd and chardev generate the instance name dynamically so it needs to be char *, but in migration it's hardcoded. Thanks, Lukas Straub