From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B7EC433E0 for ; Tue, 23 Jun 2020 11:07:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3036D2072E for ; Tue, 23 Jun 2020 11:07:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZjyRJXcS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3036D2072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnglj-0005G1-AK for qemu-devel@archiver.kernel.org; Tue, 23 Jun 2020 07:07:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jngl8-0004qA-Ch for qemu-devel@nongnu.org; Tue, 23 Jun 2020 07:06:34 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:60539 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jngl6-0007eZ-GE for qemu-devel@nongnu.org; Tue, 23 Jun 2020 07:06:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592910391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZZndPcptz55FjJA9JmenfKTWyiKAibv2FipgTjIQXrs=; b=ZjyRJXcSjrofSqVZmOt2onuKGBlaU710LWoHFupr7IUSGxe//gxyeYrH3ycpr6Ji3AEfpU AT0ovKwiiUXpey5BK+iWEFBV0kmHCVwkIuTRggiz0VSWnFY7UxDD8S55qON/CvELQvQkEb tbUcz25BnkOFCjgvio9IRRSUJFiiLAI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-27--vL5aZmSOoqX2Y51hBqBrw-1; Tue, 23 Jun 2020 07:06:27 -0400 X-MC-Unique: -vL5aZmSOoqX2Y51hBqBrw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E97C88005AD; Tue, 23 Jun 2020 11:06:24 +0000 (UTC) Received: from gondolin (ovpn-112-222.ams2.redhat.com [10.36.112.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id A84455DAA0; Tue, 23 Jun 2020 11:06:14 +0000 (UTC) Date: Tue, 23 Jun 2020 13:06:12 +0200 From: Cornelia Huck To: "Dr. David Alan Gilbert" Subject: Re: [PATCH QEMU v25 12/17] vfio: Add function to start and stop dirty pages tracking Message-ID: <20200623130612.16eefe35.cohuck@redhat.com> In-Reply-To: <20200623110125.GD3328@work-vm> References: <1592684486-18511-1-git-send-email-kwankhede@nvidia.com> <1592684486-18511-13-git-send-email-kwankhede@nvidia.com> <20200623123216.17eefe2e.cohuck@redhat.com> <20200623110125.GD3328@work-vm> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/23 02:54:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cjia@nvidia.com, aik@ozlabs.ru, Zhengxiao.zx@alibaba-inc.com, shuangtai.tst@alibaba-inc.com, qemu-devel@nongnu.org, peterx@redhat.com, Kirti Wankhede , eauger@redhat.com, yi.l.liu@intel.com, quintela@redhat.com, ziye.yang@intel.com, armbru@redhat.com, mlevitsk@redhat.com, pasic@linux.ibm.com, felipe@nutanix.com, zhi.a.wang@intel.com, kevin.tian@intel.com, yan.y.zhao@intel.com, alex.williamson@redhat.com, changpeng.liu@intel.com, eskultet@redhat.com, Ken.Xue@amd.com, jonathan.davies@nutanix.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 23 Jun 2020 12:01:25 +0100 "Dr. David Alan Gilbert" wrote: > * Cornelia Huck (cohuck@redhat.com) wrote: > > On Sun, 21 Jun 2020 01:51:21 +0530 > > Kirti Wankhede wrote: > > > > > Call VFIO_IOMMU_DIRTY_PAGES ioctl to start and stop dirty pages tracking > > > for VFIO devices. > > > > > > Signed-off-by: Kirti Wankhede > > > Reviewed-by: Dr. David Alan Gilbert > > > --- > > > hw/vfio/migration.c | 36 ++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 36 insertions(+) > > > > > > diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c > > > index faacea5327cb..e0fbb3a01855 100644 > > > --- a/hw/vfio/migration.c > > > +++ b/hw/vfio/migration.c > > > @@ -11,6 +11,7 @@ > > > #include "qemu/main-loop.h" > > > #include "qemu/cutils.h" > > > #include > > > +#include > > > > > > #include "sysemu/runstate.h" > > > #include "hw/vfio/vfio-common.h" > > > @@ -329,6 +330,32 @@ static int vfio_load_device_config_state(QEMUFile *f, void *opaque) > > > return qemu_file_get_error(f); > > > } > > > > > > +static int vfio_start_dirty_page_tracking(VFIODevice *vbasedev, bool start) > > > > I find 'start' functions that may also stop something a bit confusing. > > Maybe vfio_toggle_dirty_page_tracking()? > > I don't think toggle is any better; I always think of toggle as flipping > the state to the other state. > vfio_set_dirty_page_tracking maybe? Sounds good to me.