From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0896C433DF for ; Mon, 13 Jul 2020 10:47:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 738562072D for ; Mon, 13 Jul 2020 10:47:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yl2jh1os" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 738562072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1juvzN-0002Sv-OS for qemu-devel@archiver.kernel.org; Mon, 13 Jul 2020 06:47:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juvyV-0001kW-JS for qemu-devel@nongnu.org; Mon, 13 Jul 2020 06:46:19 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:39006 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1juvyS-0002Ke-WC for qemu-devel@nongnu.org; Mon, 13 Jul 2020 06:46:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594637174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1jxpVee2D2CXrF+i6ydsiXVPDag0mghqFYfQw0e8lrs=; b=Yl2jh1osFZlFBSNvVDsmV0Z41Gh3krxpMEYmD27maVz0mB31VJRX3v8z6afsBj+/QcmhCy bbT8G5WsG4sSAvsCfeVPhYWp7jcU1SLLSEU/nCAcNwNyVzVAwnCN3eKzv0GHNlq/4U3FEi bhYYn/QhjkumRZa4M6tRxBfsHPICGAY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-336-8rhfVA_xM5aSQWNEUqK6Tw-1; Mon, 13 Jul 2020 06:46:13 -0400 X-MC-Unique: 8rhfVA_xM5aSQWNEUqK6Tw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B69228014D4; Mon, 13 Jul 2020 10:46:10 +0000 (UTC) Received: from gondolin (ovpn-113-13.ams2.redhat.com [10.36.113.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2AB4D7846C; Mon, 13 Jul 2020 10:46:07 +0000 (UTC) Date: Mon, 13 Jul 2020 12:46:04 +0200 From: Cornelia Huck To: Claudio Fontana Subject: Re: [PATCH 3/3] cpu-timers, icount: new modules Message-ID: <20200713124604.5fcc8282.cohuck@redhat.com> In-Reply-To: References: <20200629093504.3228-1-cfontana@suse.de> <20200629093504.3228-4-cfontana@suse.de> <20200710083356.4c6e9f78.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/13 01:36:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , "Jason J. Herne" , Philippe =?UTF-8?B?TWF0aGlldS1EYXVk?= =?UTF-8?B?w6k=?= , Marcelo Tosatti , Markus Armbruster , qemu-devel@nongnu.org, Roman Bolshakov , Wenchao Wang , haxm-team@intel.com, Colin Xu , Paolo Bonzini , Sunil Muthuswamy , Richard Henderson , Alex =?UTF-8?B?QmVubsOpZQ==?= , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 10 Jul 2020 21:20:08 +0200 Claudio Fontana wrote: > >>> In short this goes away if I again set icount to enabled for qtest, > >>> basically ensuring that --enable-tcg is there and then reenabling icount. > >>> > >>> qtest was forcing icount and shift=0 by creating qemu options, in order to misuse its counter feature, > >>> instead of using a separate counter. > >>> > >>> Removing that ugliness we end up with different behavior of save/load, because vmstate will now suddenly not contain icount-related values anymore. > >>> What I do not understand is why this causes a problem because save should just not store the icount state and load should just not load the icount state, > >>> and why we die on the load of s390 keys state (it works just fine for other architectures). > > > > Yes, I don't really see why skeys is so special. No endianness stuff, I > > assume? > > > No, does not seem to be the issue. Hm, had been worth a thought. > > I discovered a way simpler way to "fix" it: > > static bool icount_state_needed(void *opaque) > { > return 1; > } > > Ie, making sure that the state is always saved/restored, even when unused. > > Really weird. > > I logged/debugged the vmstate code, and I can see that things seem symmetric between save and load when it comes to timers. > > something puts 0s into the key somehow... Maybe writing one 0 to many?