From: David Gibson <david@gibson.dropbear.id.au>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Fam Zheng" <fam@euphon.net>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] .travis.yml: skip ppc64abi32-linux-user with plugins
Date: Wed, 15 Jul 2020 14:06:19 +1000 [thread overview]
Message-ID: <20200715040619.GG93134@umbus.fritz.box> (raw)
In-Reply-To: <20200714175516.5475-1-alex.bennee@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 3013 bytes --]
On Tue, Jul 14, 2020 at 06:55:16PM +0100, Alex Bennée wrote:
> We actually see failures on threadcount running without plugins:
>
> retry.py -n 1000 -c -- \
> ./ppc64abi32-linux-user/qemu-ppc64abi32 \
> ./tests/tcg/ppc64abi32-linux-user/threadcount
>
> which reports:
>
> 0: 978 times (97.80%), avg time 0.270 (0.01 varience/0.08 deviation)
> -6: 21 times (2.10%), avg time 0.336 (0.01 varience/0.12 deviation)
> -11: 1 times (0.10%), avg time 0.502 (0.00 varience/0.00 deviation)
> Ran command 1000 times, 978 passes
>
> But when running with plugins we hit the failure a lot more often:
>
> 0: 91 times (91.00%), avg time 0.302 (0.04 varience/0.19 deviation)
> -11: 9 times (9.00%), avg time 0.558 (0.01 varience/0.11 deviation)
> Ran command 100 times, 91 passes
>
> The crash occurs in guest code which is the same in both pass and fail
> cases. However we see various messages reported on the console about
> corrupted memory lists which seems to imply the guest memory allocation
> is corrupted. This lines up with the seg fault being in the guest
> __libc_free function. So we think this is a guest bug which is
> exacerbated by various modes of translation. If anyone has access to
> real hardware to soak test the test case we could prove this properly.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Honestly, AFAICT the ppc64abi32-linux-user target is pretty much
entirely broken anyway. Many things about it appear to make no
sense, it's difficult to work out what it's even supposed to be, and I
strongly suspect no-one's actually used it in like a decade.
> ---
> .travis.yml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index ab429500fc..6695c0620f 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -350,9 +350,10 @@ jobs:
> # Run check-tcg against linux-user (with plugins)
> # we skip sparc64-linux-user until it has been fixed somewhat
> # we skip cris-linux-user as it doesn't use the common run loop
> + # we skip ppc64abi32-linux-user as it seems to have a broken libc
> - name: "GCC plugins check-tcg (user)"
> env:
> - - CONFIG="--disable-system --enable-plugins --enable-debug-tcg --target-list-exclude=sparc64-linux-user,cris-linux-user"
> + - CONFIG="--disable-system --enable-plugins --enable-debug-tcg --target-list-exclude=sparc64-linux-user,cris-linux-user,ppc64abi32-linux-user"
> - TEST_BUILD_CMD="make build-tcg"
> - TEST_CMD="make check-tcg"
> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg"
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-15 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 17:55 [PATCH] .travis.yml: skip ppc64abi32-linux-user with plugins Alex Bennée
2020-07-14 19:29 ` Philippe Mathieu-Daudé
2020-07-15 4:06 ` David Gibson [this message]
2020-07-15 8:02 ` Alex Bennée
2020-07-15 8:56 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715040619.GG93134@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).