From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15EA9C433E1 for ; Wed, 15 Jul 2020 13:52:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D59BB20657 for ; Wed, 15 Jul 2020 13:52:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H6yqQvAu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D59BB20657 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jvhpj-0002DC-WF for qemu-devel@archiver.kernel.org; Wed, 15 Jul 2020 09:52:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvhow-0001ln-Ur for qemu-devel@nongnu.org; Wed, 15 Jul 2020 09:51:38 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:23564 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jvhou-0004yF-Tq for qemu-devel@nongnu.org; Wed, 15 Jul 2020 09:51:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594821095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UN5soKaOwoUz+tG5eU8l26rbAUC+AEwZw19ioFyWUY8=; b=H6yqQvAuzBUxVK0CdYFWcxVE3mTHacq1sd9EVnPBmGQbmePKj2WF4rSfvB2KQMItOy/YT+ HlEZoG8v2wYwuaymFcA2A5PNIgqdW3t4ewhrMCYXUgiEBalzm9CjOiWaSF/b/5RUWvVnx5 ryPnEtfXlYTyDSie4RbFCBFmpT7A/WQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-Ztf3Ac1HPbmhMyMjmuR51Q-1; Wed, 15 Jul 2020 09:51:31 -0400 X-MC-Unique: Ztf3Ac1HPbmhMyMjmuR51Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A772D5AF00; Wed, 15 Jul 2020 13:51:30 +0000 (UTC) Received: from localhost (unknown [10.40.208.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 826BA5C57D; Wed, 15 Jul 2020 13:51:25 +0000 (UTC) Date: Wed, 15 Jul 2020 15:51:23 +0200 From: Igor Mammedov To: Jon Doron Subject: Re: [PATCH v5 1/2] acpi: i386: Move VMBus DSDT entry to SB Message-ID: <20200715155123.77fc5d60@redhat.com> In-Reply-To: <20200715084326.678715-2-arilou@gmail.com> References: <20200715084326.678715-1-arilou@gmail.com> <20200715084326.678715-2-arilou@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=imammedo@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/15 02:37:05 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rvkagan@yandex-team.ru, pbonzini@redhat.com, vkuznets@redhat.com, mail@maciej.szmigiero.name, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 15 Jul 2020 11:43:25 +0300 Jon Doron wrote: > Signed-off-by: Jon Doron Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index b7bcbbbb2a..7708a27f70 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -975,7 +975,6 @@ static Aml *build_vmbus_device_aml(VMBusBridge *vmbus_bridge) > > static void build_isa_devices_aml(Aml *table) > { > - VMBusBridge *vmbus_bridge = vmbus_bridge_find(); > bool ambiguous; > Object *obj = object_resolve_path_type("", TYPE_ISA_BUS, &ambiguous); > Aml *scope; > @@ -986,10 +985,6 @@ static void build_isa_devices_aml(Aml *table) > build_acpi_ipmi_devices(scope, BUS(obj), "\\_SB.PCI0.ISA"); > isa_build_aml(ISA_BUS(obj), scope); > > - if (vmbus_bridge) { > - aml_append(scope, build_vmbus_device_aml(vmbus_bridge)); > - } > - > aml_append(table, scope); > } > > @@ -1485,6 +1480,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, > PCIBus *bus = NULL; > TPMIf *tpm = tpm_find(); > int i; > + VMBusBridge *vmbus_bridge = vmbus_bridge_find(); > > dsdt = init_aml_allocator(); > > @@ -1526,6 +1522,12 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, > } > } > > + if (vmbus_bridge) { > + sb_scope = aml_scope("_SB"); > + aml_append(sb_scope, build_vmbus_device_aml(vmbus_bridge)); > + aml_append(dsdt, sb_scope); > + } > + > if (pcmc->legacy_cpu_hotplug) { > build_legacy_cpu_hotplug_aml(dsdt, machine, pm->cpu_hp_io_base); > } else {