From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D7BC433E3 for ; Wed, 22 Jul 2020 11:06:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD965206F5 for ; Wed, 22 Jul 2020 11:06:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MqkW8oba" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD965206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyCaA-0007sf-4C for qemu-devel@archiver.kernel.org; Wed, 22 Jul 2020 07:06:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyCZY-0007Jc-7h for qemu-devel@nongnu.org; Wed, 22 Jul 2020 07:06:04 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:26724 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jyCZV-0005R6-EU for qemu-devel@nongnu.org; Wed, 22 Jul 2020 07:06:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595415959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zQ44fNy1YsqR28Ov9hjKhfyTrKptf30+CyJLa+qa9g8=; b=MqkW8obaUWDZpFrMMI/LKtLdalLIuUU92zs9eAIsVmlfwjAAQXpgWTCvxV19l9LIrB6Nc8 3rBprxQ+/uJptTVxlfjmJIF1ulIUFigqop6VJ2avmy9e+DpxKDOmr8E7E+H2wJJ2AlA4WJ WpYhKKapVzxPdm0583BF2twkFOrKxXo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-174-y5lNWJIqPjazXtyLDSuAuw-1; Wed, 22 Jul 2020 07:05:56 -0400 X-MC-Unique: y5lNWJIqPjazXtyLDSuAuw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E11BA18C63ED for ; Wed, 22 Jul 2020 11:05:50 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-115-89.ams2.redhat.com [10.36.115.89]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A349101042E; Wed, 22 Jul 2020 11:05:50 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 93C3E9D9F; Wed, 22 Jul 2020 13:05:49 +0200 (CEST) Date: Wed, 22 Jul 2020 13:05:49 +0200 From: Gerd Hoffmann To: Christophe de Dinechin Subject: Re: [PATCH v5 03/10] qdev: device module support Message-ID: <20200722110549.utfggzytjvedjmoo@sirius.home.kraxel.org> References: <20200624131045.14512-1-kraxel@redhat.com> <20200624131045.14512-4-kraxel@redhat.com> <7hft9mmfg6.fsf@turbo.dinechin.lan> <20200721142753.v2be4d2mdh435gtv@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=kraxel@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/21 23:27:14 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Eduardo Habkost , qemu-devel@nongnu.org, Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jul 22, 2020 at 10:05:51AM +0200, Christophe de Dinechin wrote: > > On 2020-07-21 at 16:27 CEST, Gerd Hoffmann wrote... > > Hi, > > > >> > DeviceState *qdev_new(const char *name) > >> > { > >> > + if (!object_class_by_name(name)) { > >> > + module_load_qom_one(name); > >> > + } > >> > >> Curious why you don't you call module_object_class_by_name here? > > > > Because object_new() wants a name not an ObjectClass ... > > I'm talking about the two lines above. > > if (!object_class_by_name(name)) { > module_load_qom_one(name); > } > > Thi9s code looks very similar to the code below: > > ObjectClass *module_object_class_by_name(const char *typename) > { > ObjectClass *oc; > > oc = object_class_by_name(typename); > #ifdef CONFIG_MODULES > if (!oc) { > module_load_qom_one(typename); > oc = object_class_by_name(typename); > } > #endif > return oc; > } > > Both call module_load_qom_one and object_class_by_name using the name as > input, so I don't see the difference (except for the order). Yes, calling module_object_class_by_name then throw away the result would work too. I don't like the idea to hide the module loading though. take care, Gerd