From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: fam@euphon.net, Stefan Weil <sw@weilnetz.de>,
richard.henderson@linaro.org, qemu-devel@nongnu.org,
f4bug@amsat.org, cota@braap.org, aurelien@aurel32.net
Subject: Re: [PATCH v2 05/12] util/oslib-win32: add qemu_get_host_physmem implementation
Date: Wed, 22 Jul 2020 12:38:21 +0100 [thread overview]
Message-ID: <20200722113821.GD2324845@redhat.com> (raw)
In-Reply-To: <87wo2vu6lg.fsf@linaro.org>
On Wed, Jul 22, 2020 at 12:33:47PM +0100, Alex Bennée wrote:
>
> Stefan Weil <sw@weilnetz.de> writes:
>
> > Am 22.07.20 um 08:28 schrieb Alex Bennée:
> >
> >> It seems GetPhysicallyInstalledSystemMemory isn't available in the
> >> MinGW headers so we have to declare it ourselves. Compile tested only.
> >
> >
> > It is available, at least for Mingw-w64 which I also use for cross
> > builds on Debian, but is only included with _WIN32_WINNT >= 0x0601.
> >
> > Currently we set _WIN32_WINNT to 0x0600.
>
> That would explain why some people see things working if they build with
> visual studio (which I presume has a higher setting). We could just wrap
> the body of the function in:
No, that's not how it works. We define _WIN32_WINNT in qemu/osdep.h,
and this causes the Windows headers to hide any functions that post-date
that version.
This is similar to how you might set _POSIX_C_SOURCE / _XOPEN_SOURCE
to control UNIX header visibility.
IOW, the use of visual studio shouldn't affect it.
> #if (_WIN32_WINNT >= 0x0601)
>
> much like in commands-win32.c?
>
> Of course it wouldn't even be compile tested (I used the fedora docker
> image). We should probably clean up the test-mingw code to work with
> both the fedora and debian-w[32|64] images.
I'd just go for GlobalMemoryStatusEx like Stefan suggests. We use this
in libvirt and GNULIB already and it does the job.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-07-22 11:39 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 6:28 [PATCH v2 00/12] candidate fixes for 5.1-rc1 (testing, semihosting, OOM tcg, x86 fpu) Alex Bennée
2020-07-22 6:28 ` [PATCH v2 01/12] shippable: add one more qemu to registry url Alex Bennée
2020-07-22 6:28 ` [PATCH v2 02/12] semihosting: defer connect_chardevs a little more to use serialx Alex Bennée
2020-07-22 6:28 ` [PATCH v2 03/12] semihosting: don't send the trailing '\0' Alex Bennée
2020-07-22 6:28 ` [PATCH v2 04/12] util: add qemu_get_host_physmem utility function Alex Bennée
2020-07-22 15:51 ` Richard Henderson
2020-07-22 6:28 ` [PATCH v2 05/12] util/oslib-win32: add qemu_get_host_physmem implementation Alex Bennée
2020-07-22 6:49 ` Philippe Mathieu-Daudé
2020-07-22 10:03 ` Stefan Weil
2020-07-22 10:13 ` Daniel P. Berrangé
2020-07-22 11:33 ` Alex Bennée
2020-07-22 11:38 ` Daniel P. Berrangé [this message]
2020-07-22 10:32 ` 罗勇刚(Yonggang Luo)
2020-07-22 10:50 ` Stefan Weil
2020-07-22 11:31 ` Alex Bennée
2020-07-22 11:41 ` Daniel P. Berrangé
2020-07-22 6:28 ` [PATCH v2 06/12] accel/tcg: better handle memory constrained systems Alex Bennée
2020-07-22 15:57 ` Richard Henderson
2020-07-22 16:29 ` Alex Bennée
2020-07-22 16:44 ` Daniel P. Berrangé
2020-07-22 19:02 ` Richard Henderson
2020-07-23 9:00 ` Daniel P. Berrangé
2020-07-23 9:22 ` Alex Bennée
2020-07-23 9:31 ` Daniel P. Berrangé
2020-07-23 10:06 ` Alex Bennée
2020-07-22 6:28 ` [PATCH v2 07/12] target/i386: floatx80: avoid compound literals in static initializers Alex Bennée
2020-07-22 6:45 ` Philippe Mathieu-Daudé
2020-07-22 6:28 ` [PATCH v2 08/12] linux-user: don't use MAP_FIXED in pgd_find_hole_fallback Alex Bennée
2020-07-22 16:00 ` Richard Henderson
2020-07-22 6:28 ` [PATCH v2 09/12] tests/docker: fix update command due to python3 str/bytes distinction Alex Bennée
2020-07-22 6:29 ` [PATCH v2 10/12] tests/docker: fix binfmt_misc image building Alex Bennée
2020-07-22 6:35 ` Philippe Mathieu-Daudé
2020-07-22 6:29 ` [PATCH v2 11/12] tests/docker: add support for DEB_KEYRING Alex Bennée
2020-07-22 14:27 ` Philippe Mathieu-Daudé
2020-07-22 16:03 ` Richard Henderson
2020-07-22 6:29 ` [PATCH v2 12/12] linux-user: fix clock_nanosleep() Alex Bennée
2020-07-22 6:49 ` Laurent Vivier
2020-07-22 8:33 ` Laurent Vivier
2020-07-22 8:55 ` Alex Bennée
2020-07-22 12:03 ` Laurent Vivier
2020-07-22 7:05 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722113821.GD2324845@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).