From: Josh DuBois <duboisj@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Josh DuBois <josh@joshdubois.com>
Subject: [PATCH] trace/simple: Allow enabling simple traces from command line
Date: Thu, 23 Jul 2020 00:33:59 -0500 [thread overview]
Message-ID: <20200723053359.256928-1-josh@joshdubois.com> (raw)
The simple trace backend is enabled / disabled with a call
to st_set_trace_file_enabled(). When initializing tracing
from the command-line, this must be enabled on startup.
(Prior to db25d56c014aa1a9, command-line initialization of
simple trace worked because every call to st_set_trace_file
enabled tracing.)
Fixes: db25d56c014aa1a96319c663e0a60346a223b31e
Signed-off-by: Josh DuBois <josh@joshdubois.com>
---
trace/control.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/trace/control.c b/trace/control.c
index 2ffe000818..6558b5c906 100644
--- a/trace/control.c
+++ b/trace/control.c
@@ -225,6 +225,7 @@ void trace_init_file(const char *file)
{
#ifdef CONFIG_TRACE_SIMPLE
st_set_trace_file(file);
+ st_set_trace_file_enabled(true);
#elif defined CONFIG_TRACE_LOG
/*
* If both the simple and the log backends are enabled, "--trace file"
--
2.25.1
next reply other threads:[~2020-07-23 7:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 5:33 Josh DuBois [this message]
2020-07-29 13:05 ` [PATCH] trace/simple: Allow enabling simple traces from command line Stefan Hajnoczi
2020-07-30 22:50 ` Josh DuBois
2020-08-03 9:08 ` Markus Armbruster
2020-08-04 17:41 ` Josh DuBois
2020-08-05 4:38 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723053359.256928-1-josh@joshdubois.com \
--to=duboisj@gmail.com \
--cc=josh@joshdubois.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).