From: Stefan Hajnoczi <stefanha@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: dmitry.fleytman@gmail.com, mst@redhat.com, liq3ea@gmail.com,
liq3ea@163.com, qemu-devel@nongnu.org, alxndr@bu.edu,
Michael Tokarev <mjt@tls.msk.ru>,
pbonzini@redhat.com
Subject: Re: [PATCH 2/2] e1000e: make TX reentrant
Date: Thu, 23 Jul 2020 13:01:21 +0100 [thread overview]
Message-ID: <20200723120121.GF186372@stefanha-x1.localdomain> (raw)
In-Reply-To: <7dc09488-c73c-c016-735e-8316273c3322@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 372 bytes --]
On Thu, Jul 23, 2020 at 10:25:35AM +0800, Jason Wang wrote:
>
> On 2020/7/22 下午8:53, Michael Tokarev wrote:
> > FWIW, this is not "making TX reentrant", it is about forbidding
> > reentrancy instead :)
> >
> > /mjt
>
>
> Indeed, I will rename the title.
Please also include a comment explaining the purpose of the early return
in the code.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-23 12:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 8:57 [PATCH 1/2] net: forbid the reentrant RX Jason Wang
2020-07-22 8:57 ` [PATCH 2/2] e1000e: make TX reentrant Jason Wang
2020-07-22 11:24 ` Li Qiang
2020-07-23 2:22 ` Jason Wang
2020-07-22 12:53 ` Michael Tokarev
2020-07-23 2:25 ` Jason Wang
2020-07-23 12:01 ` Stefan Hajnoczi [this message]
2020-07-23 10:36 ` Peter Maydell
2020-07-24 4:00 ` Jason Wang
2020-07-28 4:00 ` [PATCH 1/2] net: forbid the reentrant RX Jason Wang
2020-09-02 15:56 ` Alexander Bulekov
2020-09-03 3:56 ` Jason Wang
2020-09-03 4:02 ` Alexander Bulekov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723120121.GF186372@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=alxndr@bu.edu \
--cc=dmitry.fleytman@gmail.com \
--cc=jasowang@redhat.com \
--cc=liq3ea@163.com \
--cc=liq3ea@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).