From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F92C433E4 for ; Mon, 27 Jul 2020 11:52:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13512206E7 for ; Mon, 27 Jul 2020 11:52:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Sb4NTcuP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13512206E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k01gf-0004K7-CX for qemu-devel@archiver.kernel.org; Mon, 27 Jul 2020 07:52:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k01g2-0003rL-Im for qemu-devel@nongnu.org; Mon, 27 Jul 2020 07:52:18 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:34240 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k01g1-0002JR-0v for qemu-devel@nongnu.org; Mon, 27 Jul 2020 07:52:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595850736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PGX4nePZzpl0B0T0U74S2GYRCzRvbprNIt3g58XuY8k=; b=Sb4NTcuPR71V+QHrdpxIlyEek+6WG9PiqIlsyagHqGUV9Mi88oUS9B9s3G89qj1Fo/MpSY Ho55OYsCSiZZqPeaM+GxBtoCSJhDhbeuUMQ6BLuqWPYrHEpsPDWAlW3s/j6ohST8Ofv9b9 kN0GeA4jxTyBbCKwGr/tsrVtBWHFtQo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-97-v499F4AoOr6fOAWyn0laEw-1; Mon, 27 Jul 2020 07:52:14 -0400 X-MC-Unique: v499F4AoOr6fOAWyn0laEw-1 Received: by mail-wr1-f71.google.com with SMTP id m7so3835065wrb.20 for ; Mon, 27 Jul 2020 04:52:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PGX4nePZzpl0B0T0U74S2GYRCzRvbprNIt3g58XuY8k=; b=C7P7DKJ/Ku60lD60VX4HFsfGbKvI56jef0fkREoHIpwxuw9w0pd547GiAY1lq5l+Gj x/C23n+eq0bnpRJJ9fwSyFS1coxce2/Zq08BMj4BRiQbAxu+UOuL3YZuAKiWYaI4ylEq JzdginTxdEAqk01VS1il54Bbci1EtUhmwimsQ1ZqUH4lqSeTXI4/fJQuBDmXmD8YnmF3 OikJTquuwswqJcm/FtOaEsYlvzgpdPVp2mJaiq81ry4nUGVP+nOKgBZmswzCr0iKMJxO ZCM1dJMPGGixiEGMJMcgJHZljRWfk7RY+agLkgOprdChIPkrYbsDpTmaSBNpx41jXaUY SZLg== X-Gm-Message-State: AOAM530/zUYKC6g7XvWAV07lk53uhXbFqZbOOJGaPRJqmXD7aR/sOmlm 0OnigsbVtAxbH4TZ7NPRCtyiV2+m9orInpGOq8Oh/AQ8QP3GfDILQoVNXorgB+lPEJ+VBNc81fJ hyngsld2fBwy/Obk= X-Received: by 2002:a7b:c242:: with SMTP id b2mr1876059wmj.90.1595850733076; Mon, 27 Jul 2020 04:52:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxC09qWnMMWKvEuv0Ki0aXfi0R6O5LAjIGM3kClgJ3RWAeuJ1Q85gkJZIxvSEGXsAlycLaPUQ== X-Received: by 2002:a7b:c242:: with SMTP id b2mr1876046wmj.90.1595850732847; Mon, 27 Jul 2020 04:52:12 -0700 (PDT) Received: from redhat.com ([192.117.173.58]) by smtp.gmail.com with ESMTPSA id f17sm19730004wme.14.2020.07.27.04.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 04:52:12 -0700 (PDT) Date: Mon, 27 Jul 2020 07:52:09 -0400 From: "Michael S. Tsirkin" To: David Hildenbrand Subject: Re: [PATCH v1] virtio-mem-pci: force virtio version 1 Message-ID: <20200727075125-mutt-send-email-mst@kernel.org> References: <20200708143619.38743-1-david@redhat.com> <2a7d938b-cd30-4598-b151-d16dc0a2f46b@redhat.com> <20200727074404-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: <20200727074404-mutt-send-email-mst@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=mst@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 03:37:14 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jul 27, 2020 at 07:49:12AM -0400, Michael S. Tsirkin wrote: > On Mon, Jul 27, 2020 at 01:42:56PM +0200, David Hildenbrand wrote: > > On 22.07.20 16:22, David Hildenbrand wrote: > > > On 08.07.20 16:36, David Hildenbrand wrote: > > >> Let's force virtio version 1. While at it, use qdev_realize() to set > > >> the parent bus and realize - like most other virtio-*-pci > > >> implementations. > > >> > > >> Fixes: 0b9a2443a48b ("virtio-pci: Proxy for virtio-mem") > > >> Cc: Cornelia Huck > > >> Cc: "Michael S. Tsirkin" > > >> Signed-off-by: David Hildenbrand > > >> --- > > >> hw/virtio/virtio-mem-pci.c | 4 ++-- > > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/hw/virtio/virtio-mem-pci.c b/hw/virtio/virtio-mem-pci.c > > >> index 1a8e854123..831022aa86 100644 > > >> --- a/hw/virtio/virtio-mem-pci.c > > >> +++ b/hw/virtio/virtio-mem-pci.c > > >> @@ -21,8 +21,8 @@ static void virtio_mem_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp) > > >> VirtIOMEMPCI *mem_pci = VIRTIO_MEM_PCI(vpci_dev); > > >> DeviceState *vdev = DEVICE(&mem_pci->vdev); > > >> > > >> - qdev_set_parent_bus(vdev, BUS(&vpci_dev->bus)); > > >> - object_property_set_bool(OBJECT(vdev), true, "realized", errp); > > >> + virtio_pci_force_virtio_1(vpci_dev); > > >> + qdev_realize(vdev, BUS(&vpci_dev->bus), errp); > > >> } > > >> > > >> static void virtio_mem_pci_set_addr(MemoryDeviceState *md, uint64_t addr, > > >> > > > > > > Ping @mst > > > > > > > With Conny's patches in, simple virtio-mem examples currently fail with > > > > qemu-system-x86_64: -device > > virtio-mem-pci,id=vm0,memdev=mem0,node=0,requested-size=300M: device is > > modern-only, use disable-legacy=on > > > > So we really want this in QEMU 5.1 > > > > -- > > Thanks, > > > > David / dhildenb > > That's something to note in the commit log btw. Sorry, could you rebase pls? You could include the above in the commit log then. Thanks and sorry about the delay! > > -- > MST