From: David Gibson <david@gibson.dropbear.id.au>
To: Greg Kurz <groug@kaod.org>
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
qemu-ppc@nongnu.org, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH for-5.2] spapr: Avoid some integer conversions in spapr_phb_realize()
Date: Fri, 31 Jul 2020 13:22:14 +1000 [thread overview]
Message-ID: <20200731032214.GC12398@yekko.fritz.box> (raw)
In-Reply-To: <20200730185518.774172c9@bahia.lan>
[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]
On Thu, Jul 30, 2020 at 06:55:18PM +0200, Greg Kurz wrote:
> On Wed, 29 Jul 2020 12:54:41 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
> > On Tue, Jul 28, 2020 at 11:14:13AM +0200, Greg Kurz wrote:
> > > Without this patch, the irq number gets converted uselessly from int
> > > to int32_t, back and forth.
> > >
> > > This doesn't fix an actual issue, it's just to make the code neater.
> > >
> > > Suggested-by: Markus Armbruster <armbru@redhat.com>
> > > Signed-off-by: Greg Kurz <groug@kaod.org>
> >
> > Applied to ppc-for-5.2, thanks.
> >
>
> Daniel reported a crash that happens systematically on some systems that
> don't support KVM XIVE (aka. bostons) since the patch "spapr: Simplify
> error handling in spapr_phb_realize()" landed in the ppc-for-5.2 tree.
>
> The patch is good but it uncovered an issue we have in the KVM XIVE code
> in QEMU (basically we should ignore the absence of KVM XIVE device when
> claiming IRQ numbers).
>
> The fix is trivial but to avoid breaking bisect, it should rather go
> before the patch mentioned above. Also I want to consolidate the error
> handling a bit more so, in the meantime, for others to be able to use
> the ppc-for-5.2 branch, I suggest you simply drop:
>
> spapr: Simplify error handling in spapr_phb_realize()
>
> and the current patch as well since it's a follow-up.
>
> I'll send a new patchset later.
Ok, done, I've removed both those patches from ppc-for-5.2, resend the
new version whenever you're ready.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-07-31 5:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 9:14 [PATCH for-5.2] spapr: Avoid some integer conversions in spapr_phb_realize() Greg Kurz
2020-07-28 11:51 ` Markus Armbruster
2020-07-29 2:54 ` David Gibson
2020-07-30 16:55 ` Greg Kurz
2020-07-31 3:22 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731032214.GC12398@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=armbru@redhat.com \
--cc=danielhb413@gmail.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).