* [PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef
@ 2020-05-05 14:28 Philippe Mathieu-Daudé
2020-06-03 5:04 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-05 14:28 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Richard Henderson, Paolo Bonzini, Philippe Mathieu-Daudé,
Richard Henderson
Drop superfluous parenthesis around VMPortReadFunc typedef
(added in d67f679d99, missed to remove when moved in e595112985).
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/i386/vmport.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/vmport.h b/hw/i386/vmport.h
index 47eda7a22b..a6624e3045 100644
--- a/hw/i386/vmport.h
+++ b/hw/i386/vmport.h
@@ -27,7 +27,7 @@
#define TYPE_VMPORT "vmport"
-typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
+typedef uint32_t VMPortReadFunc(void *opaque, uint32_t address);
void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
--
2.21.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef
2020-05-05 14:28 [PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef Philippe Mathieu-Daudé
@ 2020-06-03 5:04 ` Philippe Mathieu-Daudé
2020-07-31 20:42 ` Eduardo Habkost
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-03 5:04 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Richard Henderson, Paolo Bonzini, Richard Henderson
On 5/5/20 4:28 PM, Philippe Mathieu-Daudé wrote:
> Drop superfluous parenthesis around VMPortReadFunc typedef
> (added in d67f679d99, missed to remove when moved in e595112985).
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/i386/vmport.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/vmport.h b/hw/i386/vmport.h
> index 47eda7a22b..a6624e3045 100644
> --- a/hw/i386/vmport.h
> +++ b/hw/i386/vmport.h
> @@ -27,7 +27,7 @@
>
> #define TYPE_VMPORT "vmport"
>
> -typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
> +typedef uint32_t VMPortReadFunc(void *opaque, uint32_t address);
>
> void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
>
>
ping?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef
2020-06-03 5:04 ` Philippe Mathieu-Daudé
@ 2020-07-31 20:42 ` Eduardo Habkost
0 siblings, 0 replies; 3+ messages in thread
From: Eduardo Habkost @ 2020-07-31 20:42 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Michael S. Tsirkin, qemu-trivial, Richard Henderson, qemu-devel,
Paolo Bonzini, Richard Henderson
On Wed, Jun 03, 2020 at 07:04:26AM +0200, Philippe Mathieu-Daudé wrote:
> On 5/5/20 4:28 PM, Philippe Mathieu-Daudé wrote:
> > Drop superfluous parenthesis around VMPortReadFunc typedef
> > (added in d67f679d99, missed to remove when moved in e595112985).
> >
> > Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > hw/i386/vmport.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/i386/vmport.h b/hw/i386/vmport.h
> > index 47eda7a22b..a6624e3045 100644
> > --- a/hw/i386/vmport.h
> > +++ b/hw/i386/vmport.h
> > @@ -27,7 +27,7 @@
> >
> > #define TYPE_VMPORT "vmport"
> >
> > -typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
> > +typedef uint32_t VMPortReadFunc(void *opaque, uint32_t address);
> >
> > void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
> >
> >
>
> ping?
Queued for 5.2. Sorry for missing it.
--
Eduardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-31 20:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-05 14:28 [PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef Philippe Mathieu-Daudé
2020-06-03 5:04 ` Philippe Mathieu-Daudé
2020-07-31 20:42 ` Eduardo Habkost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).