From: Klaus Jensen <its@irrelevant.dk>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>,
Max Reitz <mreitz@redhat.com>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v2 00/16] hw/block/nvme: dma handling and address mapping cleanup
Date: Mon, 17 Aug 2020 08:45:29 +0200 [thread overview]
Message-ID: <20200817064520.GA11110@apples.localdomain> (raw)
In-Reply-To: <20200729220638.344477-1-its@irrelevant.dk>
On Jul 30 00:06, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> This series consists of patches that refactors dma read/write and adds a
> number of address mapping helper functions.
>
> v2:
> * hw/block/nvme: add mapping helpers
> - Add an assert in case of out of bounds array access. (Maxim)
>
> * hw/block/nvme: remove redundant has_sg member
> - Split the fix for the missing qemu_iov_destroy into a fresh patch
> ("hw/block/nvme: destroy request iov before reuse"). (Minwoo)
>
> * hw/block/nvme: pass request along for tracing [DROPPED]
> - Dropped the patch and replaced it with a simple patch that just adds
> tracing to the nvme_map_prp function ("hw/block/nvme: add tracing to
> nvme_map_prp"). (Minwoo)
>
> * hw/block/nvme: add request mapping helper
> - Changed the name from nvme_map to nvme_map_dptr. (Minwoo, Maxim)
>
> * hw/block/nvme: add check for mdts
> - Don't touch the documentaiton for the cmb_size_mb and max_ioqpairs
> parameters in this patch. (Minwoo)
>
> * hw/block/nvme: refactor NvmeRequest clearing [DROPPED]
> - Keep NvmeRequest structure clearing as "before use". (Maxim)
>
> * hw/block/nvme: add a namespace reference in NvmeRequest
> * hw/block/nvme: remove NvmeCmd parameter
> - Squash these two patches together into "hw/block/nvme: add ns/cmd
> references in NvmeRequest".
>
> * hw/block/nvme: consolidate qsg/iov clearing
> - Move the qsg/iov destroys to a new nvme_req_exit function that is called
> after the cqe has been posted.
>
> * hw/block/nvme: remove explicit qsg/iov parameters
> - New patch. THe nvme_map_prp() function doesn't require the qsg and iov
> parameters since it can just get them from the passed NvmeRequest.
>
> Based-on: <20200706061303.246057-1-its@irrelevant.dk>
>
> Klaus Jensen (16):
> hw/block/nvme: memset preallocated requests structures
> hw/block/nvme: add mapping helpers
> hw/block/nvme: replace dma_acct with blk_acct equivalent
> hw/block/nvme: remove redundant has_sg member
> hw/block/nvme: destroy request iov before reuse
> hw/block/nvme: refactor dma read/write
> hw/block/nvme: add tracing to nvme_map_prp
> hw/block/nvme: add request mapping helper
> hw/block/nvme: verify validity of prp lists in the cmb
> hw/block/nvme: refactor request bounds checking
> hw/block/nvme: add check for mdts
> hw/block/nvme: be consistent about zeros vs zeroes
> hw/block/nvme: add ns/cmd references in NvmeRequest
> hw/block/nvme: consolidate qsg/iov clearing
> hw/block/nvme: use preallocated qsg/iov in nvme_dma_prp
> hw/block/nvme: remove explicit qsg/iov parameters
>
> block/nvme.c | 4 +-
> hw/block/nvme.c | 506 +++++++++++++++++++++++++++---------------
> hw/block/nvme.h | 4 +-
> hw/block/trace-events | 4 +
> include/block/nvme.h | 4 +-
> 5 files changed, 340 insertions(+), 182 deletions(-)
>
> --
> 2.27.0
>
>
Thanks for the reviews everyone.
Pushed to nvme-next.
prev parent reply other threads:[~2020-08-17 6:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 22:06 [PATCH v2 00/16] hw/block/nvme: dma handling and address mapping cleanup Klaus Jensen
2020-07-29 22:06 ` [PATCH v2 01/16] hw/block/nvme: memset preallocated requests structures Klaus Jensen
2020-07-30 10:14 ` Minwoo Im
2020-07-29 22:06 ` [PATCH v2 02/16] hw/block/nvme: add mapping helpers Klaus Jensen
2020-07-29 22:06 ` [PATCH v2 03/16] hw/block/nvme: replace dma_acct with blk_acct equivalent Klaus Jensen
2020-07-29 22:06 ` [PATCH v2 04/16] hw/block/nvme: remove redundant has_sg member Klaus Jensen
2020-07-30 10:15 ` Minwoo Im
2020-07-30 10:43 ` Maxim Levitsky
2020-07-29 22:06 ` [PATCH v2 05/16] hw/block/nvme: destroy request iov before reuse Klaus Jensen
2020-07-30 10:16 ` Minwoo Im
2020-07-30 10:43 ` Maxim Levitsky
2020-07-29 22:06 ` [PATCH v2 06/16] hw/block/nvme: refactor dma read/write Klaus Jensen
2020-07-29 22:06 ` [PATCH v2 07/16] hw/block/nvme: add tracing to nvme_map_prp Klaus Jensen
2020-07-30 10:17 ` Minwoo Im
2020-07-30 10:45 ` Maxim Levitsky
2020-07-29 22:06 ` [PATCH v2 08/16] hw/block/nvme: add request mapping helper Klaus Jensen
2020-07-30 10:19 ` Minwoo Im
2020-07-29 22:06 ` [PATCH v2 09/16] hw/block/nvme: verify validity of prp lists in the cmb Klaus Jensen
2020-07-29 22:06 ` [PATCH v2 10/16] hw/block/nvme: refactor request bounds checking Klaus Jensen
2020-07-29 22:06 ` [PATCH v2 11/16] hw/block/nvme: add check for mdts Klaus Jensen
2020-07-29 22:06 ` [PATCH v2 12/16] hw/block/nvme: be consistent about zeros vs zeroes Klaus Jensen
2020-07-29 22:06 ` [PATCH v2 13/16] hw/block/nvme: add ns/cmd references in NvmeRequest Klaus Jensen
2020-07-29 22:06 ` [PATCH v2 14/16] hw/block/nvme: consolidate qsg/iov clearing Klaus Jensen
2020-07-30 10:31 ` Minwoo Im
2020-07-30 11:02 ` Maxim Levitsky
2020-07-30 11:09 ` Klaus Jensen
2020-07-30 12:26 ` Minwoo Im
2020-07-29 22:06 ` [PATCH v2 15/16] hw/block/nvme: use preallocated qsg/iov in nvme_dma_prp Klaus Jensen
2020-07-30 10:29 ` Minwoo Im
2020-07-29 22:06 ` [PATCH v2 16/16] hw/block/nvme: remove explicit qsg/iov parameters Klaus Jensen
2020-07-30 10:30 ` Minwoo Im
2020-07-30 11:03 ` Maxim Levitsky
2020-08-17 6:45 ` Klaus Jensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817064520.GA11110@apples.localdomain \
--to=its@irrelevant.dk \
--cc=fam@euphon.net \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).