qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org,
	Stephen Checkoway <stephen.checkoway@oberlin.edu>,
	Peter Maydell <peter.maydell@linaro.org>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [RFC PATCH 3/9] qtest: Directly use global address_space_memory when no CPU available
Date: Mon, 17 Aug 2020 18:18:47 +0200	[thread overview]
Message-ID: <20200817161853.593247-4-f4bug@amsat.org> (raw)
In-Reply-To: <20200817161853.593247-1-f4bug@amsat.org>

Currently all qtest MMIO access are dispatched via the first CPU
available. This limitation doesn't allow use to use the 'none'
machine to run tests. Unleash this limitation by selecting the
global address_space_memory when no CPU is available.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 softmmu/qtest.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/softmmu/qtest.c b/softmmu/qtest.c
index 81b5110783..7f018d2faf 100644
--- a/softmmu/qtest.c
+++ b/softmmu/qtest.c
@@ -19,6 +19,7 @@
 #include "chardev/char-fe.h"
 #include "exec/ioport.h"
 #include "exec/memory.h"
+#include "exec/address-spaces.h"
 #include "hw/irq.h"
 #include "sysemu/accel.h"
 #include "sysemu/cpus.h"
@@ -276,6 +277,13 @@ static void qtest_irq_handler(void *opaque, int n, int level)
 /* Default address space for MMIO accesses */
 static AddressSpace *qtest_mem_as(void)
 {
+    if (!first_cpu) {
+        /*
+         * The 'none' machine doesn't have any CPU,
+         * directly access the main address space.
+         */
+        return &address_space_memory;
+    }
     return first_cpu->as;
 }
 
-- 
2.26.2



  parent reply	other threads:[~2020-08-17 16:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17 16:18 [RFC PATCH 0/9] hw/misc: Add support for interleaved memory accesses Philippe Mathieu-Daudé
2020-08-17 16:18 ` [RFC PATCH 1/9] memory: Initialize MemoryRegionOps for RAM memory regions Philippe Mathieu-Daudé
2020-08-18  9:52   ` P J P
2020-08-18  9:58     ` Philippe Mathieu-Daudé
2020-08-17 16:18 ` [RFC PATCH 2/9] qtest: Add local qtest_mem_as() getter Philippe Mathieu-Daudé
2020-08-17 16:18 ` Philippe Mathieu-Daudé [this message]
2020-08-17 16:18 ` [RFC PATCH 4/9] hw/misc: Add interleaver device to make interleaved memory accesses Philippe Mathieu-Daudé
2020-08-17 16:18 ` [RFC PATCH 5/9] hw/misc: Add MMIO test device Philippe Mathieu-Daudé
2020-08-17 16:18 ` [RFC PATCH 6/9] hw/core/null-machine: Allow to use the MMIO 'test' device Philippe Mathieu-Daudé
2020-08-17 16:18 ` [RFC PATCH 7/9] tests/qtest: Add generic MMIO tests Philippe Mathieu-Daudé
2020-08-17 16:18 ` [RFC PATCH 8/9] memory: Allow memory region to display its subregions own descriptions Philippe Mathieu-Daudé
2020-08-17 16:18 ` [RFC PATCH 9/9] hw/misc/interleaver: Display subregions in 'info mtree' Philippe Mathieu-Daudé
2020-08-17 20:13 ` [RFC PATCH 0/9] hw/misc: Add support for interleaved memory accesses no-reply
2020-08-22 15:15 ` Philippe Mathieu-Daudé
2020-08-22 15:17 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200817161853.593247-4-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=armbru@redhat.com \
    --cc=atar4qemu@gmail.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=lvivier@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stephen.checkoway@oberlin.edu \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).