From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B5F1C433E1 for ; Mon, 24 Aug 2020 22:09:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C7F22078A for ; Mon, 24 Aug 2020 22:09:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cGXASlED" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C7F22078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAKef-0006p0-8W for qemu-devel@archiver.kernel.org; Mon, 24 Aug 2020 18:09:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAKdM-0005Wz-5a for qemu-devel@nongnu.org; Mon, 24 Aug 2020 18:08:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46043) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kAKdI-0000rJ-TW for qemu-devel@nongnu.org; Mon, 24 Aug 2020 18:08:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598306883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uCYac54bNwTQR3R4scgo6FCqz5uUK+9qnMVNSKzEh7o=; b=cGXASlED8oEA1RcJTMc7njk1RvVAPg985zEMghZ/cZlya3+Blx/xmO4bZlFYl6bOUgUAb6 uf7SCbXJlsg2cA4TX5WQU0GihVOGXqC6uFjtY/SwRXBrSqm9z97FhPZhfdlG7EkuzMjku3 +GQwKBEzDnqrtpNVuCJboh4ybAmNMRk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-139-3pF0dEQ2OYO9pJ23Dqy9Mg-1; Mon, 24 Aug 2020 18:08:01 -0400 X-MC-Unique: 3pF0dEQ2OYO9pJ23Dqy9Mg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A74691DDEB; Mon, 24 Aug 2020 22:08:00 +0000 (UTC) Received: from localhost (unknown [10.10.67.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E4C6196FE; Mon, 24 Aug 2020 22:08:00 +0000 (UTC) Date: Mon, 24 Aug 2020 18:07:59 -0400 From: Eduardo Habkost To: Xiaoyao Li Subject: Re: [PATCH 2/2] target/i386: Add missed features to Cooperlake CPU model Message-ID: <20200824220759.GS642093@habkost.net> References: <20191225063018.20038-1-xiaoyao.li@intel.com> <20191225063018.20038-3-xiaoyao.li@intel.com> MIME-Version: 1.0 In-Reply-To: <20191225063018.20038-3-xiaoyao.li@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/24 17:59:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.956, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Paolo Bonzini , Cathy Zhang , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Dec 25, 2019 at 02:30:18PM +0800, Xiaoyao Li wrote: > It lacks VMX features and two security feature bits (disclosed recently) in > MSR_IA32_ARCH_CAPABILITIES in current Cooperlake CPU model, so add them. > > Fixes: 22a866b6166d ("i386: Add new CPU model Cooperlake") > Signed-off-by: Xiaoyao Li > --- > target/i386/cpu.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 50 insertions(+), 1 deletion(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index e1eb9f473989..c9798ac8652b 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -3198,7 +3198,8 @@ static X86CPUDefinition builtin_x86_defs[] = { > CPUID_7_0_EDX_SPEC_CTRL_SSBD | CPUID_7_0_EDX_ARCH_CAPABILITIES, > .features[FEAT_ARCH_CAPABILITIES] = > MSR_ARCH_CAP_RDCL_NO | MSR_ARCH_CAP_IBRS_ALL | > - MSR_ARCH_CAP_SKIP_L1DFL_VMENTRY | MSR_ARCH_CAP_MDS_NO, > + MSR_ARCH_CAP_SKIP_L1DFL_VMENTRY | MSR_ARCH_CAP_MDS_NO | > + MSR_ARCH_CAP_PSCHANGE_MC_NO | MSR_ARCH_CAP_TAA_NO, This seems to break on some Cooperlake hosts, see: https://bugzilla.redhat.com/show_bug.cgi?id=1860743 Are all Cooperlake hosts supposed to have TAA_NO set? Are there hosts where this requires a microcode update to be installed? -- Eduardo