From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33386C433DF for ; Tue, 25 Aug 2020 09:00:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F31EE2067C for ; Tue, 25 Aug 2020 09:00:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Xm410D6M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F31EE2067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAUp1-0002iB-64 for qemu-devel@archiver.kernel.org; Tue, 25 Aug 2020 05:00:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAUoC-0002AC-75 for qemu-devel@nongnu.org; Tue, 25 Aug 2020 05:00:00 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:32234 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kAUoA-0003Yt-02 for qemu-devel@nongnu.org; Tue, 25 Aug 2020 04:59:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598345996; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=21X8Lfh7GxJsVbJpciiN0q5eVKNS8soyxYzRJ7btzsk=; b=Xm410D6MKkoryWGRE/oYEucThQRnPTUky6XUiKQmz+AUHapmqWyk7F7Y06BOxaI+9/5jUz 9Zepab3/id/UNuoVU4f8gu5855ePvWnV7pmPanAdw7NgopP/hP58pHuF5VQGFmYyyW66aG zAfuums3sI1tQgXRQr6KBpdbJ79IuTc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-M-S_aw-gOEqn6V5bLIyHFQ-1; Tue, 25 Aug 2020 04:59:54 -0400 X-MC-Unique: M-S_aw-gOEqn6V5bLIyHFQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6FBE318A2250; Tue, 25 Aug 2020 08:59:53 +0000 (UTC) Received: from redhat.com (ovpn-114-231.ams2.redhat.com [10.36.114.231]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B9D25C1CF; Tue, 25 Aug 2020 08:59:52 +0000 (UTC) Date: Tue, 25 Aug 2020 09:59:49 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: luoyonggang@gmail.com Subject: Re: [PATCH 4/5] meson: !/bin/sh are msys2 friendly. Message-ID: <20200825085949.GC107278@redhat.com> References: <20200825083500.359-1-luoyonggang@gmail.com> <20200825083500.359-4-luoyonggang@gmail.com> MIME-Version: 1.0 In-Reply-To: <20200825083500.359-4-luoyonggang@gmail.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/25 01:36:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.956, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Paolo Bonzini , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Aug 25, 2020 at 04:34:59PM +0800, luoyonggang@gmail.com wrote: > From: Yonggang Luo > > --- > scripts/undefsym.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/undefsym.sh b/scripts/undefsym.sh > index b9ec332e95..8189308b2c 100755 > --- a/scripts/undefsym.sh > +++ b/scripts/undefsym.sh > @@ -1,4 +1,4 @@ > -#! /usr/bin/env bash > +#!/bin/sh Does this script actually work on non-bash shells ? If not, then this change will likely break on plaforms where /bin/sh is not bash. > > # Before a shared module's DSO is produced, a static library is built for it > # and passed to this script. The script generates -Wl,-u options to force > -- > 2.27.0.windows.1 > > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|